Conversation
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I can't confirm that this is actually working, at least in OS 8. I seem to lose the ability to activate Orca with this branch
| @@ -1,5 +1,4 @@ | |||
| [GNOME Session] | |||
| Name=Pantheon (Wayland) | |||
| RequiredComponents=@SESSION_COMPONENTS@ | |||
There was a problem hiding this comment.
Hm why are we removing the required components lines here?
There was a problem hiding this comment.
This option was dropped in gnome 49
https://gitlab.gnome.org/GNOME/gnome-session/-/commit/5501833ebb1915bf3b6539b0c1f4751a910a7886
garaevdi
force-pushed
the
remove-autostarts
branch
from
4d3df85 to
a3ef3d2
Compare
@danirabbit can you check again please. I forgot about OS8 and removed all autostarts related code. Now it checks gsd version and builds autostarts when the version is lower than 49. As for RequiredComponents key, even if it was removed in 49, a few extra lines in a session file wouldn't hurt. The same can be said about systemd config files: even if OS8 doesn't have all the unit files listed there, it shouldn't be a problem. |
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Two super tiny comments otherwise this looks good to me. Sorry it took me a while to review!
| 'gala-wayland', | ||
| gsd_components | ||
| ] | ||
|
|
There was a problem hiding this comment.
Can you leave this whitespace please
session/meson.build
Outdated
|
|
||
| foreach component : gsd_components | ||
| original_filename = component + '.desktop' | ||
| gsd_dep = dependency('gnome-settings-daemon', version: '>= 3.36.0') |
There was a problem hiding this comment.
I think we should leave this dependency variable in the toplevel meson file. It makes it easier to see and manage our dependencies
garaevdi
force-pushed
the
remove-autostarts
branch
from
a3ef3d2 to
61254fc
Compare
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Awesome, thank you! I confirmed that this doesn't break OS 8 either. Great job 👏
2 participants
Closes #97
Supersedes #99
Besides the mentioned gsd autostarts, this PR also changes other autostarts to a systemd dependency, just in case. Perhaps systemd section shouldn't be a dumb copy+paste of the same loop but I couldn't come up with something better.
Edit:
Also closes #88