Skip to content

Add processor and graphics header label titles - #548

Open
vjr wants to merge 3 commits into
mainfrom
vishal/graphics-label
Open

vjr wants to merge 3 commits into
mainfrom
vishal/graphics-label

Conversation

@vjr

@vjr vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member

Be consistent with other sections in the system view viz. memory, network and storage.

Be consistent with other sections in the system view viz. memory, network and storage.
@vjr vjr self-assigned this Sep 14, 2026
@vjr
vjr requested review from a team, danirabbit and stsdc September 14, 2026 13:43
Comment thread src/Widgets/WidgetResource/WidgetResource.vala Outdated
@stsdc

stsdc commented Sep 14, 2026

Copy link
Copy Markdown
Member

I actually wanted to go another way and replace generic text with the actual hardware names, if we have some.
I think we can save some space by just prepending hardware name with its type: "Processor: Intel Smoothie Lake ..."

@danirabbit

Copy link
Copy Markdown
Member

@stsdc I think using header with secondary text is better than combining strings with : and for most people " Intel Smoothie Lake…" probably doesn't mean anything at all. Maybe "Intel" is a big enough brand name to know it's a processor, but otherwise the actual hardware names are probably not particularly interesting information unless you're using it to disambiguate.

Personally, I would even say to go the other way and not list any hardware names unless we're disambiguating like what Networking does. We do list hardware details already in System Settings.

The question I think to ask is, what problem does having the hardware name here solve? I'm not sure it does anything for us to have it

@vjr

vjr commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

I think it's useful to keep it as a quick glance at CPU+GPU info, it's just a one-liner :-)

BTW I'm unable to figure out how to bottom-valign the round popover info-button, it looks a bit off towards the higher side to me, tried a few properties in Gtk.Box and the child MenuButton widget to no avail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants