Skip to content

Some storage info cleanup in system view - #547

Open
vjr wants to merge 3 commits into
mainfrom
vishal/disk-size
Open

vjr wants to merge 3 commits into
mainfrom
vishal/disk-size

Conversation

@vjr

@vjr vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member
  • Remove IEC_UNITS flag to show more relevant storage capacity info.
  • Remove showing of used space info which is likely incorrect especially for multiple partitions with only some mounted.
  • Remove "not mounted" label altogether now that free/used info is gone, was it really useful?

Before and after screenshots: #547 (comment)

vjr added 3 commits September 14, 2026 17:48
Because storage devices typically advertise their capacities in "base 1000" rather than "base 1024".
A disk advertised as having 2 TB capacity previously showed as 1.8 TiB in the system view.
With this diff it now shows as 2 TB which is what a user would expect to see.
It usually shows larger usage because free space (which is used to calculate usage) is counted for only mounted volumes and won't work for multiple partitions with only some mounted.
Not really useful info after removal of free/used info?
Also, edge case of it potentially showing "not mounted" if free space really is zero.
@vjr vjr self-assigned this Sep 14, 2026
@vjr
vjr requested review from a team, danirabbit and stsdc September 14, 2026 12:43
@flodavid

Copy link
Copy Markdown

Could you add before-after screenshots please ?

@vjr

vjr commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

Could you add before-after screenshots please ?

BEFORE:

monitor-storage-before

AFTER:

monitor-storage-after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants