Show sub-GHz CPU frequency in MHz instead of always GHz

[vjr]

No description provided.

[danirabbit]

Definitely moving this to a utility is great. I think we should follow how GLib format_size works here at least for localization. They have great comments and it seems they translate the unit separately from the final string (probably for RTL or languages that don’t use spaces etc) https://github.com/GNOME/glib/blob/main/glib/gutils.c#L2834

[vjr]

Definitely moving this to a utility is great. I think we should follow how GLib format_size works here at least for localization. They have great comments and it seems they translate the unit separately from the final string (probably for RTL or languages that don’t use spaces etc) https://github.com/GNOME/glib/blob/main/glib/gutils.c#L2834

Kool - can we leave the glib style translation part for another PR? I'm not adept in this area so either someone who can or I can work on it later. Existing main branch also lacks this glib style translation.

[stsdc]

Looks like there is a conversion issue now on graph and Indicator.
Graph height is 4GHz

[vjr]

Looks like there is a conversion issue now on graph and Indicator. Graph height is 4GHz

@stsdc fixed in 60056b3

[vjr]

Definitely moving this to a utility is great. I think we should follow how GLib format_size works here at least for localization. They have great comments and it seems they translate the unit separately from the final string (probably for RTL or languages that don’t use spaces etc) https://github.com/GNOME/glib/blob/main/glib/gutils.c#L2834

@danirabbit i've made RTL/LTR in 9aa933e but can revert this commit if not ok - otherwise there doesn't seem to be a localisation regression from main branch.

Addressed in 9aa933e

[vjr]

Addressed #541 (review) in bd9dffa

[vjr]

Further review comments in #541 (review) addressed in 724fa66 hope it's better now @ryonakano ?

[vjr]

Argh! Thanks for your patience @ryonakano I hope 3a32e82 finally addresses all remaining feedback?

[ryonakano]

The frequency area is shown as dimmed on my side. Is this expected?

Before

After

[vjr]

@ryonakano thanks for catching this, it is also evident in dark mode but i did not even notice it! should be fixed by 3305fd8 which was just a hunch!

[ryonakano]

LGTM, thanks.