ci: use electron/semantic-trusted-release instead of npx#127
Merged
MarshallOfSound merged 1 commit intomainfrom Mar 31, 2026
Merged
ci: use electron/semantic-trusted-release instead of npx#127MarshallOfSound merged 1 commit intomainfrom
MarshallOfSound merged 1 commit intomainfrom
Conversation
Replaces unpinned npx semantic-release with the org-standard electron/semantic-trusted-release composite action. The previous invocation fetched semantic-release@latest from the registry on every release with publish credentials in scope. The .releaserc.json already matches what secret-service-action uses (commit-analyzer, release-notes-generator, github — all bundled with semantic-release core), so no config changes needed. Also: - drops the redundant setup-node step (the composite action has its own) - adds persist-credentials: false on checkout - adds pull-requests/issues write permissions for release comments
erickzhao
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces unpinned
npx semantic-releasewith the org-standardelectron/semantic-trusted-releasecomposite action.The problem:
This fetches
semantic-release@latestfrom npm on every release run, withGITHUB_TOKEN(contents: write) in scope. A compromised semantic-release release would get code execution with push-tag/create-release privileges.The fix:
electron/semantic-trusted-releaseinstalls semantic-release from a frozenyarn.lock— same pattern already used by 26 other repos in the org (secret-service-actionis the closest analog since it's also a GitHub Action, not an npm package).The existing
.releaserc.jsonis already identical tosecret-service-action's — justcommit-analyzer/release-notes-generator/@semantic-release/github, all bundled with semantic-release core. No config changes needed.Also in this PR:
persist-credentials: falseon checkout (semantic-release uses the passed-in token, not checkout creds)pull-requests: write/issues: writepermissions so semantic-release can comment on linked PRs/issues with the release version