Skip to content

feat: isolate run button #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsanders11 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: isolate run button #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion forge.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const config: ForgeConfig = {
name: '@electron-forge/plugin-webpack',
config: {
devContentSecurityPolicy:
"default-src 'none'; img-src 'self' https: data:; media-src 'none'; child-src 'self'; object-src 'self'; script-src 'self'; style-src 'self' 'unsafe-inline'; connect-src 'self' https:; font-src 'self' https:;",
"default-src 'none'; img-src 'self' https: data:; media-src 'none'; child-src 'self' isolated-actions:; object-src 'self'; script-src 'self'; style-src 'self' 'unsafe-inline'; connect-src 'self' https:; font-src 'self' https:;",
devServer: {
// Disallow browser from opening/reloading with HMR in development mode.
open: false,
Expand All @@ -55,6 +55,11 @@ const config: ForgeConfig = {
js: path.join(root, 'src/preload/preload.ts'),
},
},
{
html: path.join(root, './static/isolated-run-button.html'),
js: path.join(root, './src/isolated-run-button.ts'),
name: 'isolated_run_button',
},
],
},
},
Expand Down
1 change: 0 additions & 1 deletion src/ambient.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ declare global {
setShowMeTemplate(template?: string): void;
showWarningDialog(messageOptions: MessageOptions): void;
showWindow(): void;
startFiddle(): Promise<void>;
stopFiddle(): void;
themePath: string;
uncacheTypes(ver: RunnableVersion): Promise<void>;
Expand Down
2 changes: 2 additions & 0 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ export const ELECTRON_DTS = 'electron.d.ts';
// We use these to fail fast locally when creating/updating a new gist.
export const GIST_MAX_FILE_SIZE = 10 * 1024 * 1024; // 10 MB per file
export const GIST_MAX_FILE_COUNT = 300;

export const PREFERS_DARK_MEDIA_QUERY = '(prefers-color-scheme: dark)';
1 change: 1 addition & 0 deletions src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ export type FiddleEvent =
| 'select-all-in-editor'
| 'set-show-me-template'
| 'show-welcome-tour'
| 'theme-loaded'
| 'toggle-bisect'
| 'toggle-monaco-option'
| 'undo-in-editor'
Expand Down
1 change: 1 addition & 0 deletions src/ipc-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export enum IpcEvents {
OPEN_THEME_FOLDER = 'OPEN_THEME_FOLDER',
READ_THEME_FILE = 'READ_THEME_FILE',
GET_THEME_PATH = 'GET_THEME_PATH',
THEME_LOADED = 'THEME_LOADED',
IS_DEV_MODE = 'IS_DEV_MODE',
NPM_ADD_MODULES = 'NPM_ADD_MODULES',
NPM_IS_PM_INSTALLED = 'NPM_IS_PM_INSTALLED',
Expand Down
Loading
Loading