fix: avoid startup crash when V8 sandbox is disabled

[david-metrica]

Description of Change

Fixes #49199

This fixes startup crash in custom builds where V8 sandbox is disabled.

32-bit builds do not enable the V8 sandbox, so checking ARCH_CPU_32_BIT alongside !V8_ENABLE_SANDBOX is redundant.

For more information refer to:
#49199 (Issue where this was solved)
#48699 (Same problem but the issue was unresolved)

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• relevant API documentation, tutorials, and examples are updated and follow the documentation style guide
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

notes: Fixed startup crash when V8 sandbox is disabled.

[deepak1556]

Please follow the steps here to edit and re-export the existing patch https://github.com/electron/electron/blob/main/docs/development/patches.md#editing-an-existing-patch

[david-metrica]

Please follow the steps here to edit and re-export the existing patch https://github.com/electron/electron/blob/main/docs/development/patches.md#editing-an-existing-patch

Hello @deepak1556 ,

Sorry if this is a basic question, but I’m not entirely sure how this process works.

The instructions say:

Editing an existing patch
$ cd src/v8
$ vim some/code/file.cc

I assume this means I need to run gclient sync and then modify the same files that the existing patch touches. However, I’m unsure on how the tooling knows which specific patch I’m editing.

The instructions also mention:
“Find the commit SHA of the patch you want to edit.”

Which commit SHA is this referring to?

• The commit I originally created?
• The latest revision of the patch?
• Or the original commit where the patch was first introduced?

I apologise if this is obvious, I’m a bit lost on the workflow here.

Also, I’m currently in transit (flying from Asia to Europe), so I won’t be able to update this pull request until Friday.

Thanks in advance for your help.

[nikwen]

Using build-tools:

1. cd src/electron
2. git checkout fix/v8-sandbox-disabled-build
3. e sync
4. e patches chromium
5. git commit -m "chore: update patch"

[david-metrica]

Everything should be fine now. Please let me know if I missed something.

[ckerr]

32-bit builds do not enable the V8 sandbox, so checking ARCH_CPU_32_BIT alongside !V8_ENABLE_SANDBOX is redundant.

This is probably obvious, but just to make it explicit for anyone reading this: the V8 Sandbox requires a 64-bit system so it should be safe to replace ARCH_CPU_32_BIT with V8_ENABLE_SANDBOX as this PR does

[ckerr]

LGTM.

[deepak1556]

LGTM, Thanks!

[dsanders11]

@david-metrica, could you update this PR to have signed commits? This repo enforces commit signatures, so the lack of them in this PR blocks merging here.

[david-metrica]

@dsanders11 Sorry! I didn't notice that! It should be fine now. Let me know if I am missing anything else.

[codebytere]

@david-metrica could you rebase this? then we can get it merged :)

[david-metrica]

@codebytere Please check. It should be fine now.

[jkleinsc]

@david-metrica can you rebase one more time? There was an issue on main that has now been resolved.

[david-metrica]

@david-metrica can you rebase one more time? There was an issue on main that has now been resolved.

@jkleinsc @codebytere Done!

[release-clerk]

Release Notes Persisted

Fixed startup crash when V8 sandbox is disabled.

[trop]

I have automatically backported this PR to "41-x-y", please check out #49504

[trop]

I have automatically backported this PR to "40-x-y", please check out #49505

[ckerr]

/trop run backport-to 40-x-y

[trop]

The backport process for this PR has been manually initiated - sending your PR to 40-x-y!

[trop]

I have automatically backported this PR to "40-x-y", please check out #49884