fix: serialize close with in-flight queries - #1089
Open
seanwessmith wants to merge 3 commits into
Open
Conversation
seanwessmith
marked this pull request as ready for review
August 18, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
A query can pass
_checkReady()and still be waiting between protocol phases whenclose()deactivates the backend. The query then entersexecProtocolRawSync()against an inactive backend and can block the event loop permanently.The close path now preserves call order: work invoked before
close()drains under the existing transaction/query mutex order, while work invoked afterward seesPGlite is closing.Fixes #1084.
Related work
#1063 addresses a separate close race with detached filesystem syncs. Both changes affect shutdown ordering and may require conflict resolution if #1063 lands first; this PR specifically serializes
close()with in-flight query and transaction work.Validation
Using the current-main Node 24 WASM artifact from #1087, from
packages/pglite:../../node_modules/.bin/tsup ../../node_modules/.bin/tsc --noEmit ../../node_modules/.bin/eslint ./src ./tests --report-unused-disable-directives --max-warnings 0 ../../node_modules/.bin/prettier --check ./src ./tests ./node_modules/.bin/vitest run tests/targets/runtimes/node-close.test.js ./node_modules/.bin/vitest run tests/targets/runtimes/node-*.test.js