Conversation
Add -DCMAKE_COMPILE_WARNING_AS_ERROR=ON to the debug Linux x86_64 CI build step. PR elastic#2985 reduced compiler warnings to zero on this configuration; this flag makes any regression an immediate build failure rather than a silent accumulation. The flag is scoped to the existing debug PR build step only, leaving release and cross-compile configurations unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pinging @elastic/ml-core (Team:ML) |
edsavage
force-pushed
the
fix/werror-debug-linux-ci
branch
from
September 17, 2026 03:28
884b942 to
1eab514
Compare
…t (revert me)" This reverts commit 1eab514.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The remaining feedback is a non-blocking test-coverage nit.
Pull request overview
Enforces zero compiler warnings in the Linux x86_64 debug CI build.
Changes:
- Enables
CMAKE_COMPILE_WARNING_AS_ERROR=ONfor the debug build. - Leaves release and cross-compile configurations unchanged.
File summaries
| File | Summary |
|---|---|
.buildkite/pipelines/build_linux.json.py |
Adds warning-as-error enforcement; a non-blocking nit requests coverage verifying the flag remains scoped correctly. |
Review details
Suppressed comments (1)
.buildkite/pipelines/build_linux.json.py:240
- The existing pipeline-generator tests only assert that the debug step's label is present; they never inspect its environment. A later edit could remove this warning-as-error flag (or apply it to the wrong step) while all current tests still pass. Add coverage that finds the debug build step and asserts this flag is present, while the release/cross-compile steps remain unchanged.
"CMAKE_FLAGS": "-DCMAKE_TOOLCHAIN_FILE=cmake/linux-x86_64.cmake -DML_FAST_DEBUG=ON -DCMAKE_UNITY_BUILD=ON -DML_PCH=ON -DCMAKE_COMPILE_WARNING_AS_ERROR=ON",
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-DCMAKE_COMPILE_WARNING_AS_ERROR=ONto the debug Linux x86_64 CI build stepTest plan