Conversation
|
Pinging @elastic/ml-core (Team:ML) |
edsavage
added
auto-backport
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Tests assert unavailable generator behavior, and the suite is not registered in CI.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds pytest coverage for Buildkite PR pipeline label, comment, and environment-handling paths.
Changes:
- Adds subprocess-based pipeline generator tests.
- Covers platform labels, QA/PyTorch triggers, comments, and environment overrides.
File summaries
| File | Summary |
|---|---|
dev-tools/unittest/test_pr_pipeline.py |
Adds PR pipeline generator tests, including cases for behavior not currently implemented. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
buildkite build |
Exercises every label/comment code path in pipeline.json.py that calls os.environ, so that a missing import (or similar name error) is caught by the dev-tools pytest CI step before it reaches a real PR build. The test was prompted by a missing 'import os' on the 9.4 branch that caused any backport PR carrying ci:run-qa-tests to fail in ~25s before any build step ran. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
edsavage
force-pushed
the
add/pr-pipeline-tests
branch
from
September 16, 2026 23:24
de0b01a to
4c34d9c
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
dev-tools/unittest/test_pr_pipeline.pyto exercise every label- and comment-triggered code path in.buildkite/pipeline.json.pythat callsos.environ. Thedev-tools pytestCI step already runs this directory, so coverage is automatic on every PR.Motivated by a missing
import oson the9.4branch (fixed separately) that caused any backport PR carryingci:run-qa-teststo crash the pipeline generator before any build step ran.Test plan
mainbranch.ci:run-qa-tests,ci:run-pytorch-tests, both together (dedup check),QAF_TESTS_TO_RUNenv override, comment-triggeredrun_qa_tests, comment-triggeredrun_pytorch_tests, and a parametrised check that every label variant producessteps+envkeys.9.5,9.4,9.99) so the same protection exists there.🤖 Generated with Claude Code