[9.4] [ML] Fix missing import os in PR pipeline generator - #3196
Merged
Merged
Conversation
pipeline.json.py uses os.environ.get() inside the ci:run-qa-tests code path but was missing 'import os'. Any PR carrying the ci:run-qa-tests label triggered a NameError that crashed the pipeline generator in ~25s, blocking the entire Buildkite build before any step ran. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pinging @elastic/ml-core (Team:ML) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipeline.json.pyusesos.environ.get()inside theci:run-qa-testscode path but was missingimport os. Any PR carrying theci:run-qa-testslabel triggered aNameErrorthat crashed the pipeline generator in ~25s, blocking the entire Buildkite build before any step ran.Discovered via backport PR #3194, whose
ci:run-qa-testslabel (inherited from the original) entered this path for the first time on9.4.Only
9.4is affected —main,9.5, and9.99already haveimport os;9.3and earlier don't useos.environin this script at all.Test plan
main(add/pr-pipeline-tests) addsdev-tools/unittest/test_pr_pipeline.py, which exercises everyos.environ-touching code path and will be backported to active branches including9.4.🤖 Generated with Claude Code