Conversation
An empty servers page is noise for readers. Presence now follows ReadServers. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
The next lines already add the generated OpenAPI items. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4118/ Sample changed pages: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| | `operation` | Operation pages use `/operation/` | | ||
| | `authentication` | Each API product has an `/authentication` page | | ||
| | `servers` | Each API product has a `/servers` page | | ||
| | `servers` | Reserved for the `/servers` page when the spec declares servers | |
Contributor
There was a problem hiding this comment.
[LOW] Reserved slug wording no longer matches runtime validation
This row says servers is only reserved when the spec declares servers, but slug validation still rejects servers unconditionally via ApiUrlBuilder.ReservedChildSegments. That means a no-servers spec still cannot use children: - file: servers.md, so this wording is currently inaccurate.
Suggested change
| | `servers` | Reserved for the `/servers` page when the spec declares servers | | |
| | `servers` | Reserved for API Explorer and cannot be used as a child file slug | |
Member
Author
There was a problem hiding this comment.
Fixed in 3ff7bfb — reserved-slug docs now match ReservedChildSegments, which still rejects servers and authentication unconditionally. I applied the same wording to the authentication row.
Bump.sh keeps Authentications in the sidebar only when schemes exist. An empty Authentication page is the same dead end as an empty Servers page. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
reakaleek
changed the title
…-actions) ReservedChildSegments still rejects servers and authentication unconditionally. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API product with no
serversor no security schemes no longer gets an empty Servers or Authentication page.Affects: API reference, Isolated builds
Prompt summary: Hide the servers page when the API spec does not declare servers, instead of showing "This API does not declare servers." Also hide the authentication page when the spec has no schemes, matching how bump.sh keeps Authentications out of an empty state and keeps Servers out of the sidebar.
Why
serversstill produced a/serverspage whose body is "This API does not declare servers."What
StructuralNavigationItem.Createadds Authentication only whenHasSchemesis true, and Servers only whenReadServersis non-empty.authenticationandserversstay reserved child slugs even when those pages are omitted.Notes
Hiddenwould still write the page.OpenApiGenerator.RenderNavigationItemswalks every leaf./serversURL.Verify