Skip to content

Avoid Python shell in composite actions - #4089

Open
Mpdreamz wants to merge 1 commit into
mainfrom
fix/zizmor-python-shell-cleanup
Open

Mpdreamz wants to merge 1 commit into
mainfrom
fix/zizmor-python-shell-cleanup

Conversation

@Mpdreamz

Copy link
Copy Markdown
Member

Converts the AWS role ARN helper steps in .github/actions/aws-auth/action.yml and actions/update-link-index/action.yml from Python to Bash so zizmor can analyze the GITHUB_OUTPUT writes without its unsupported Python-shell warning.

This is split out from #4080 because the warning is non-blocking and should get a separate review.

Validation:

  • Compared the generated ARN output against the previous Python implementation for both prefixes.
  • Ran pinned zizmor v1.30.0 against the two touched action definitions.
  • Pre-commit hook passed.

Convert the AWS role ARN helpers to Bash so zizmor can analyze the action output writes without hitting its unsupported Python-shell warning. The generated role names stay equivalent to the previous Python implementation.
@github-actions

Copy link
Copy Markdown
Contributor

Docs preview (local build)

Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4089/

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.


What is this? | From workflow: PR Review

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@Mpdreamz Mpdreamz added the chore label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants