Conversation
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4075/ Sample changed pages: |
There was a problem hiding this comment.
Requesting changes: --no-overwrite currently uses a non-atomic check-then-put path, so concurrent uploads can still overwrite existing objects. Please enforce no-overwrite with conditional S3 writes and handle precondition failures as not-overwritten conflicts.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
Requesting changes: --no-overwrite should treat unchanged inline marker content as skipped, not as a not-overwritten conflict that forces a non-zero result.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
Requesting changes.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
Requesting changes.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
No new actionable findings.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
Requesting changes.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| --overwrite | ||
| ``` | ||
|
|
||
| ```sh |
There was a problem hiding this comment.
[NITPICK] Duplicate example block appears twice
The ### Explicit overwrite section includes the same command snippet twice in succession. Removing the duplicate block will keep the docs concise and avoid suggesting there are two different variants.
Addresses #4071
Summary
Add
changelog uploadoption to prevent replacing existing S3 objects.Every run now also reports how many objects were new versus replaced.
Details
Per #4075 (review) I've changed this PR so overwriting will no longer be the default, but this will be accomplished in a phased way to avoid breaking existing teams' GitHub actions:
--overwritewhile default remains replace (Overwrite still true unless we invert later).--overwrite(no-op initially): Support --overwrite option in changelog upload docs-actions#346Overwrite option
This PR adds the
--overwritecommand option and it matches the current behaviour of always replacing (i.e. overwrite defaults to true).The
--skip-etag-checkoption implies overwrite.Count new versus replaced on every run
The completion line is now
N uploaded (X new, Y replaced), Z skipped, W failed. Refused Puts appear asnot overwrittenand are not part ofuploaded. Per-file logs add(new)or(replace). Classification uses the HeadObject call the uploader already makes.Example
NOTE: While testing in
cloudrepo, I encountered a local changelog that had multiple repos, so I refined the messaging to be clearer in that case. For example:Generative AI disclosure
Tool(s) and model(s) used: Cursor Grok 4.6