Conversation
Builder-version `?v=` no longer keeps HTMX navigation fresh and overwrites search's product-version parameter. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4074/ |
There was a problem hiding this comment.
Requesting changes: this update removes DocsBuilderVersion from GlobalLayoutViewModel but leaves a remaining initializer in tests/Navigation.Tests/Rendering/FooterRenderingTests.cs, which breaks Navigation.Tests compilation with CS0117.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| @@ -37,7 +37,6 @@ public record CodexBreadcrumb(string Title, string? Url); | |||
|
|
|||
| public record GlobalLayoutViewModel | |||
| { | |||
There was a problem hiding this comment.
[HIGH] Removing DocsBuilderVersion leaves the test suite uncompilable
Deleting this property breaks at least one remaining object initializer that still sets it (tests/Navigation.Tests/Rendering/FooterRenderingTests.cs, DocsBuilderVersion = "test"). That causes CS0117 in Navigation.Tests, so this PR currently does not build for that test project.
Please remove the stale assignment(s) in tests (or keep a compatible property while all call sites are migrated).
HTMX navigation no longer appends a builder-version
?v=query string. Request URLs match the page URL, and the same key no longer overwrites search's product-version filter.Affects: Site UI, API reference, Codex builds
Prompt summary: Remove the HTMX GET
?v=cache-buster. It existed for out-of-band swap cache invalidation that no longer applies.Why
HTMX GET requests append a builder-version
vquery string so caches do not serve stale HTML during out-of-band swaps. Navigation now useshx-booston#main-container. HTMX history is already off, and static assets already use a content hash. The samevkey overwrites the product-version filter on full-page search.What
HTMX request URLs
Boosted GET requests no longer receive a builder-version
vparameter. History updates no longer strip that parameter. The request URL and the address bar stay aligned with the page URL.Layout model
The layout no longer carries
DocsBuilderVersionordata-docs-builder-version. Markdown, Codex, and API pages stop hashing the builder version into every view model.Synthetics
The
/docs/apijourney still asserts a full page load throughisNavigationRequest(). It no longer treats a missingvparameter as proof the click was not HTMX.Verify
Out of scope: Search still uses
?v=for the product version. Static files still use?v={contentHash}.Made with Cursor