Conversation
A catalog click is a full page load. Shared view-transition names let the mark and title move to the heading. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4069/ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to me.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
The morphing names and @view-transition on API layouts added snapshot cost for a transition we do not want. The landing heading still shows the product mark. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Requesting changes: the new landing-heading test currently uses a generic <svg assertion that can pass even when the product mark is absent; please make the assertion landing-specific.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
| .ReadAllTextAsync(Path.Join(outputRoot, "api", "doc", "elasticsearch", "index.html"), TestContext.Current.CancellationToken); | ||
| html.Should().Contain("api-landing-heading"); | ||
| html.Should().Contain("<h1>Elasticsearch main</h1>"); | ||
| html.Should().Contain("<svg"); |
There was a problem hiding this comment.
This assertion is too broad for the behavior under test. The page layout always contains an inline <svg> sprite (_GlobalLayout.cshtml), so this check can pass even if the landing product mark is missing. Please assert against landing-scoped markup instead (for example api-landing-icon, or that the icon span contains the expected product icon SVG).
There was a problem hiding this comment.
Fixed in 9db80c2 — the test now asserts api-landing-icon and the Elasticsearch product mark viewBox, not a bare <svg.
The layout sprite always includes an svg, so a bare tag check can pass without the product mark. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Approved — no actionable issues found.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
Reviewed the API landing update and tests. The product mark now comes from the shared icon registry, the fallback remains safe when no icon exists, and CI is green.
2 participants
API product landing pages now show the same product mark as the catalog card, next to the spec title.
Affects: API reference, Site UI
Prompt summary: Show the product logo and spec name on API spec pages, starting with the product landing page only. Keep the heading like a hub page. Do not add the mark to operations, tags, or types yet.
Why
Catalog cards already show a product mark. The spec landing page is still a bare title, so a click from the catalog loses that identity.
What
Landing heading
The product landing page puts the mark and spec title in one row. The mark comes from
ProductIconsusing the product id, then the API key. A missing mark leaves the title alone. No initials fallback.Heading size
The landing
h1uses the same type as the catalog header. The mark is 40px tall so it sits with that title.Out of scope
Operation, tag, and type pages are unchanged.
Verify
Open a catalog card, then confirm the landing heading shows the mark beside the spec title.