Conversation
The assembler landing page still paints a hamburger when TopNav exists, even though the site-root drawer has no links. This test renders that layout and expects the control to be absent. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
The site-root nav HTML is always empty, and the landing drawer only fills when navigation-preview is on. The hamburger still appeared because TopNav exists, so mobile users opened a blank panel. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Landing no longer reads RenderHamburgerIcon, and the test no longer needs a TopNav parent to reproduce the empty drawer. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/4068/ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Approved — no blocking issues found.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
The version dropdown is first in the TOC DOM, so mobile flex must reverse and space the two controls apart. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
With the flag on, mobile hides the desktop top bar and puts section and version controls in the pages drawer. The landing page is the only layout without a TOC hamburger, so it still needs that trigger when the drawer has content. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
#toc-nav only had top padding from 1280px up, so at laptop widths the picker sat flush on the secondary nav. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Mpdreamz
approved these changes
Sep 14, 2026
Mpdreamz
left a comment
Mpdreamz
left a comment
Member
There was a problem hiding this comment.
Reviewed the rendering change and tests. The new landing predicate lines up with what the mobile pages drawer actually renders, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs landing page no longer shows a hamburger that opens an empty drawer. Article pages keep the hamburger on the left of the version picker, and the picker sits 24px under the secondary nav at every width.
Affects: Site UI, Navigation
Prompt summary: Hide the empty hamburger on the docs landing page. Later asks on the same branch keep that hamburger when
navigation-previewfills the drawer, put it left of the version picker, and add space between the secondary nav and the version picker.Why
The assembler site-root nav HTML is always empty. The landing layout still rendered a hamburger when
TopNavor the version dropdown existed, so the drawer opened blank withnavigation-previewoff. When that flag is on, the same drawer holds section and version controls, so landing needs the hamburger. On article pages the TOC row did not reverse on small screens, and#toc-navonly padded from 1280px up, so the version picker sat flush on the secondary nav at laptop widths.What
Landing hamburger
The landing hamburger renders only when the mobile drawer has content: non-empty
NavigationHtml, ornavigation-previewwith top-nav links or a version dropdown. Flag-off landing stays empty-hamburger-free.Mobile TOC row
The TOC row uses
flex-row-reversebelowmdso the hamburger is on the left and the version picker is on the right. Both controls share one baseline.Version picker spacing
#toc-navnow has 24px top padding at every width, matching the breadcrumbs. Below 1280px the picker no longer sits on the secondary nav border.Tests
Landing layout tests cover the empty-hamburger case and the
navigation-previewdrawer. TOC tests assert the reversed row.Verify
On an article page, check a phone width and a window around 1100px: hamburger left of the version picker, 24px under the secondary nav. On
/withnavigation-previewoff, there is no hamburger.Out of scope: Article pages still open the pages-nav drawer from the TOC hamburger. Flag-off landing has no mobile pages-nav entry point.