Conversation
Preview comments need builder URLs, not guessed paths from GitHub file lists.
new(comparer)[...] is invalid C#. Pass the collection and comparer as separate constructor arguments.
Cover GetChanges, CI file lists, and include mapping without a real .git folder.
dotnet format --verify-no-changes treats a non-static local function as a lint failure.
The page was linked from index.md but not listed in _docset.yml, so --strict CI failed.
Named branches often do not exist in local clones or shallow checkouts. The first parent still gives a usable diff.
dotnet format --verify-no-changes treats new[] as IDE0300.
Mpdreamz
requested changes
Sep 14, 2026
Mpdreamz
left a comment
Member
There was a problem hiding this comment.
One blocker before this is ready: GitChangedFileSource.ResolveDiffBase returns origin/<GITHUB_BASE_REF> immediately without checking that the ref exists. On pull_request CI with a shallow merge checkout, GITHUB_BASE_REF is set but origin/main is not necessarily present, so git diff origin/main HEAD can fail and the exporter will write an empty changed-pages.json instead of falling back to HEAD^1. The docs and tests say named bases fall back when missing, but that path is skipped for GITHUB_BASE_REF. Please verify the GitHub base ref before returning it, or make the diff step fall back when that ref is unusable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What
gitdiffexporter that writeschanged-pages.jsonduring isolated builds.Notes
elastic/docs-actionsPR before preview comments use the new artifact.pagesarray and logs a warning.Made with Cursor