Navigation: use content hash for sidebar tree IDs - #3750
Open
reakaleek wants to merge 2 commits into
Open
Conversation
Different sidebars could share the same nav-tree id when docsets lacked a project key, breaking htmx preserve. Map navigation to a render model, hash the tree once per root, and cache renders by root identity. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve _TocTree.cshtml conflict by keeping main's removal of sidebar navigation-search and dropping the unused ShowSearch render-model flag. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nav-tree-*id based on its rendered content, not the navigation root idWhy
nav-tree-*id when docsets lack aprojectkey indocset.ymlhx-preservethen keeps the wrong sidebar DOM and expand/collapse state when moving between those pagesNotes
Made with Cursor