Skip to content

Docs site: improve HTML accessibility and keyboard navigation - #3748

Draft
reakaleek wants to merge 3 commits into
mainfrom
cursor/564d5f0f
Draft

Docs site: improve HTML accessibility and keyboard navigation#3748
reakaleek wants to merge 3 commits into
mainfrom
cursor/564d5f0f

Conversation

@reakaleek

Copy link
Copy Markdown
Member

What

  • Fix invalid HTML patterns in navigation, layout, and image previews
  • Add skip navigation, landmark labels, and keyboard-friendly controls
  • Replace checkbox/label sidebar toggles with proper buttons and native dialog elements

Why

  • Accessibility audit of elastic.co/docs found markup issues that hurt screen reader users and keyboard navigation
  • Invalid nesting and missing accessible names fail WCAG requirements and W3C validation checks

Notes

  • Includes minimal CSS/JS needed to preserve existing behavior with the new semantic markup
  • Regression tests added for layout shell, heading permalinks, and image dialogs

Made with Cursor

Fix invalid interactive nesting, add skip navigation and landmark labels,
replace checkbox/label sidebar controls with buttons, and use native dialog
for image previews. Add regression tests for the updated markup.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@reakaleek
reakaleek requested a review from a team as a code owner July 31, 2026 08:04
@reakaleek
reakaleek requested a review from theletterf July 31, 2026 08:04
@reakaleek
reakaleek marked this pull request as draft July 31, 2026 08:09
@reakaleek

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in 09e07f3.

Handle Escape explicitly for native image preview dialogs so Playwright and
keyboard users can dismiss them reliably.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants