Use UrlPathPrefix for agent-skill learn-more link#2908
Merged
theletterf merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
The hardcoded /explore-analyze/ai-features/agent-skills link didn't resolve in preview environments where the URL path has a prefix. Now computed from block.Build.UrlPathPrefix like other internal links. Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
Simpler than UrlPathPrefix computation and works correctly in all environments (production, preview, local). Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
Mpdreamz
requested changes
Mar 16, 2026
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
I do believe we expose each environments prefix on the root view model
Compute the learn-more URL from block.Build.UrlPathPrefix so it resolves correctly in all environments (production, preview, local). Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
Contributor
Author
Mpdreamz
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block.Build.UrlPathPrefixso it resolves correctly in all environments (production, preview builds, local).LearnMoreUrlproperty toAgentSkillViewModel, set by the renderer using the same prefix mechanism asGlobalLayoutViewModel.Link().Test plan
./build.sh unit-test— 301 F# + 1524 C# passed, 0 failed).