Conversation
…font - Switch color scheme from teal to poppy so the callout is visually distinct from tip admonitions. - Allow optional body content to clarify the scope of a skill; falls back to default text when no body is provided. - Unify both text lines to text-base for consistent sizing. - Update tests, renderers, and documentation accordingly. Addresses #2897 Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
|
+CC @shainaraskas |
🔍 Preview links for changed docs |
Mpdreamz
left a comment
There was a problem hiding this comment.
The orange looks to much like a warning IMO everything else lgtm
|
IMO, the button should be bottom aligned 🤷 |
|
Also, it needs to be responsive.. on mobile the button should be full width and below the text |
|
this lgtm w/ two thoughts:
agree w/ martijn + jan's comments as well. |
|
We're out of colors :D Pink, gray? What could work better? Summoning @itsalexcm |
…more - Use pink color scheme instead of poppy. - Make button bottom-aligned on desktop, full-width below text on mobile. - Body content is now supplementary: the default line always shows, and custom body text is rendered between it and the learn-more link. - Update learn-more text to "Learn more about agent skills for Elastic". Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM, we can follow up with colors :)
Co-authored-by: Claude <noreply@anthropic.com> Made-with: Cursor
|
@Mpdreamz Went for neutral / plain color, since it's more informational and the button already catches the eye. Could we deploy this version? |
Summary
{agent-skill}callout color from teal to plain/grey, matching the existing plain admonition style so it's visually distinct from tips.text-basefor consistent sizing.Addresses #2897
Test plan
./build.sh unit-test— 1524 C# + 301 F# passed, 0 failed).