Skip to content

Enhance {agent-skill} directive#2898

Merged
theletterf merged 4 commits intomainfrom
feat/agent-skill-enhancements
Mar 16, 2026
Merged

Enhance {agent-skill} directive#2898
theletterf merged 4 commits intomainfrom
feat/agent-skill-enhancements

Conversation

@theletterf
Copy link
Contributor

@theletterf theletterf commented Mar 13, 2026

Summary

  • Switches the {agent-skill} callout color from teal to plain/grey, matching the existing plain admonition style so it's visually distinct from tips.
  • Makes the layout responsive: on desktop the button is bottom-aligned to the right; on mobile it becomes full-width below the text.
  • Allows optional supplementary body content inside the directive to clarify the scope of a skill. The default "A skill is available..." line always renders, and custom text appears below it.
  • Unifies both text lines to text-base for consistent sizing.
  • Updates the learn-more line to "Learn more about agent skills for Elastic".

Addresses #2897

Test plan

  • All unit tests pass (./build.sh unit-test — 1524 C# + 301 F# passed, 0 failed).
  • Verify the rendered component uses the plain/grey color scheme.
  • Verify default text renders when no body content is provided.
  • Verify custom body content renders below the default text when provided.
  • Confirm the learn-more link and button still render in both cases.
  • Verify responsive layout: button is full-width and stacked on mobile, inline on desktop.

…font

- Switch color scheme from teal to poppy so the callout is visually
  distinct from tip admonitions.
- Allow optional body content to clarify the scope of a skill; falls
  back to default text when no body is provided.
- Unify both text lines to text-base for consistent sizing.
- Update tests, renderers, and documentation accordingly.

Addresses #2897

Co-authored-by: Claude <noreply@anthropic.com>
Made-with: Cursor
@theletterf theletterf requested review from a team as code owners March 13, 2026 15:57
@theletterf theletterf requested a review from technige March 13, 2026 15:57
@theletterf
Copy link
Contributor Author

+CC @shainaraskas

@github-actions
Copy link

github-actions bot commented Mar 13, 2026

🔍 Preview links for changed docs

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The orange looks to much like a warning IMO everything else lgtm

@reakaleek
Copy link
Member

IMO, the button should be bottom aligned 🤷

@reakaleek
Copy link
Member

Also, it needs to be responsive..

on mobile the button should be full width and below the text

@shainaraskas
Copy link
Contributor

shainaraskas commented Mar 13, 2026

this lgtm w/ two thoughts:

Allows optional body content inside the directive to clarify the scope of a skill; falls back to default text when no body is provided.

  • I wonder if the optional text should be supplementary (so people don't have to say the "a skill is available" part which I think is still nice?)

  • Can we tighten up this second line? it's getting some yucky wrapping now that the text is bigger:

    To learn more about Elastic agent skills, refer to the documentation.

    consider [Learn more about Elastic agent skills]. / [Learn more about agent skills for Elastic]. or similar :) (prob the latter to avoid collision with Elastic Agent)

agree w/ martijn + jan's comments as well.

@theletterf
Copy link
Contributor Author

We're out of colors :D

Pink, gray? What could work better? Summoning @itsalexcm

…more

- Use pink color scheme instead of poppy.
- Make button bottom-aligned on desktop, full-width below text on mobile.
- Body content is now supplementary: the default line always shows, and
  custom body text is rendered between it and the learn-more link.
- Update learn-more text to "Learn more about agent skills for Elastic".

Co-authored-by: Claude <noreply@anthropic.com>
Made-with: Cursor
@theletterf theletterf self-assigned this Mar 16, 2026
@theletterf theletterf requested a review from Mpdreamz March 16, 2026 12:52
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can follow up with colors :)

@theletterf
Copy link
Contributor Author

@Mpdreamz Went for neutral / plain color, since it's more informational and the button already catches the eye. Could we deploy this version?

@theletterf theletterf enabled auto-merge (squash) March 16, 2026 13:06
@theletterf theletterf changed the title Enhance {agent-skill} directive: poppy color, optional body, uniform font Enhance {agent-skill} directive: plain color, optional body, uniform font Mar 16, 2026
@theletterf theletterf changed the title Enhance {agent-skill} directive: plain color, optional body, uniform font Enhance {agent-skill} directive Mar 16, 2026
@theletterf theletterf merged commit 29cf50a into main Mar 16, 2026
30 checks passed
@theletterf theletterf deleted the feat/agent-skill-enhancements branch March 16, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants