Conversation
Swallowed gh api failures looked like an empty lookback, so the agent nooped instead of surfacing a token or search problem. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
theletterf
approved these changes
Sep 14, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source-sync digest step now fails when a GitHub API call errors or returns the wrong JSON shape. A lookback with no merged PRs or commits still succeeds, and the agent noops.
Prompt summary: A docs-eng-team source-sync run reported 0 changes for every source repo and still succeeded. Fail the digest on API errors so a token or search failure is not treated as an empty lookback.
Why
The digest step hid
gh apifailures behind empty JSON. The job printedtotal_changes=0and the agent nooped. A token or Search API rejection then looks like a quiet week. See the docs-eng-team run.What
Digest API calls
The search and commits calls fail the step when they exit non-zero. The step no longer substitutes an empty payload. A real empty lookback still writes
empty.marker.Payload shape
The step checks that search results have an
itemsarray and that commits are an array. A wrong shape prints the repo, the API, and a short payload snippet, then exits.Caller docs
The source-sync README states that an API failure fails the digest step. A token or permission problem is not reported as no changes.
Verify
Out of scope This PR does not change which APIs the digest uses, or the caller TokenPolicy in
docs-eng-team.Made with Cursor