Racecar consumer instrumentation improvements#1429
Open
ErvalhouS wants to merge 4 commits intoelastic:mainfrom
Open
Racecar consumer instrumentation improvements#1429ErvalhouS wants to merge 4 commits intoelastic:mainfrom
ErvalhouS wants to merge 4 commits intoelastic:mainfrom
Conversation
Member
|
@elasticmachine run elasticsearch-ci/docs |
Author
|
I don't think the tests failures had anything to do with the changes. |
Member
|
@ErvalhouS thank you for the contribution. No, the build failures are not related to your change. I'm trying to fix the build in a different PR and once that's done, I'll rebase this branch to bring in the changes. Thank you! |
07eadd5 to
ca160ef
Compare
Author
|
@picandocodigo can we trigger a re-run on CI? |
ca160ef to
6f2a0b1
Compare
|
Any news on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR adds better context to Racecar consumer transactions.
ConsumerClass#methodWhy is it important?
Right now there's only the
process.argsto differ transactions happening in different consumers, which could be problematic since it isn't the default visualization grouping from other libraries. Error handling is also not recorded, what makes transactions be stored with an unknown status.Checklist
.rubocop.yml)I have made corresponding changes to the documentationI have updated supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introducedRelated issues
Relates #1284