fix: backfill session row on out-of-order hooks, add busy_timeout#104
Open
rajkumarsakthivel wants to merge 1 commit into
Open
fix: backfill session row on out-of-order hooks, add busy_timeout#104rajkumarsakthivel wants to merge 1 commit into
rajkumarsakthivel wants to merge 1 commit into
Conversation
Two fixes for #49: 1. FOREIGN KEY constraint failed: UserPromptSubmit and PostToolUse crash when SessionStart was missed (cce serve started mid-session, dropped POST, resumed session_id). All hook handlers now call _ensure_session() which does INSERT OR IGNORE to backfill the FK target before dependent inserts. 2. database is locked: auto-prune contends with the hot insert path. Added PRAGMA busy_timeout = 5000 so concurrent writers wait up to 5 seconds instead of failing immediately. Closes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ensure_session()before FK-dependent inserts, backfilling the sessions row if SessionStart was missed (cce serve started mid-session, dropped POST, or resumed session_id)PRAGMA busy_timeout = 5000tomemory.dbconnections so concurrent writers (hooks + auto-prune) wait up to 5s instead of failing with "database is locked"Previously, every hook after a missed SessionStart would crash with
sqlite3.IntegrityError: FOREIGN KEY constraint failed, spamming the terminal with tracebacks.Closes #49