fix(nodeenv): install npm from the registry tarball on Windows

.github/workflows/tests.yml

@@ -119,6 +119,29 @@ jobs:
           export NODEENV_GIT_BASH="$(cygpath -w "$BASH")"
           pytest -m integration -k git_bash tests/ -v
 
+  # --with-npm installs npm another way on Windows (install_npm_win), one
+  # the ubuntu integration job never takes - issue #310
+  with-npm-windows:
+    runs-on: windows-latest
+    timeout-minutes: 10
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python 3.14
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.14'
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements-dev.txt
+
+      - name: Run --with-npm integration test
+        run: |
+          pytest -m integration -k with_npm tests/ -v
+
   coverage:
     runs-on: ubuntu-latest
     steps:

CHANGES

@@ -8,6 +8,11 @@ Version [unreleased]
   environment and restore it on deactivate: `npx` exports the outer prefix,
   and `npm.cmd` runs the npm it finds there instead of its own
   `#309 <https://github.com/ekalinin/nodeenv/issues/309>`_
+- `--with-npm` on Windows and Cygwin installs npm from the registry tarball
+  instead of the GitHub source archive, whose workspace symlinks unpacked as
+  text files (npm 8) and whose workspaces are missing (npm >= 9); the default
+  `--npm=latest` no longer ends in a 404 there
+  `#310 <https://github.com/ekalinin/nodeenv/issues/310>`_
 
 Version 1.11.0
 --------------

nodeenv.py

@@ -1185,12 +1185,17 @@ def install_npm(env_dir, _src_dir, args):
 
 def install_npm_win(env_dir, src_dir, args):
     """
-    Download source code for npm, unpack it
+    Download npm as published to the registry, unpack it
     and install it in virtual environment.
     """
     logger.info(' * Install npm.js (%s) ... ' % args.npm,
                 extra=dict(continued=True))
-    npm_url = 'https://github.com/npm/cli/archive/v%s.zip' % args.npm
+    # Not the GitHub source archive: its workspace symlinks unpack as text
+    # files, or the workspaces are missing from it altogether
+    # https://github.com/ekalinin/nodeenv/issues/310
+    npm_meta_url = 'https://registry.npmjs.org/npm/%s' % args.npm
+    npm_meta = json.loads(urlopen(npm_meta_url).read().decode('UTF-8'))
+    npm_url = npm_meta['dist']['tarball']
     npm_contents = io.BytesIO(urlopen(npm_url).read())
 
     bin_path = join(env_dir, 'Scripts')
@@ -1205,10 +1210,14 @@ def install_npm_win(env_dir, src_dir, args):
     if os.path.exists(join(bin_path, 'npm-cli.js')):
         os.remove(join(bin_path, 'npm-cli.js'))
 
-    with zipfile.ZipFile(npm_contents, 'r') as zipf:
-        zipf.extractall(src_dir)
+    npm_src_dir = join(src_dir, 'npm-%s' % npm_meta['version'])
+    with tarfile_open(fileobj=npm_contents) as tarf:
+        if sys.version_info >= (3, 12):
+            tarf.extractall(npm_src_dir, filter="data")
+        else:
+            tarf.extractall(npm_src_dir)
 
-    npm_ver = 'cli-%s' % args.npm
+    npm_ver = join('npm-%s' % npm_meta['version'], 'package')
     shutil.copytree(join(src_dir, npm_ver), node_modules_path)
     shutil.copy(join(src_dir, npm_ver, 'bin', 'npm.cmd'),
                 join(bin_path, 'npm.cmd'))
@@ -1220,9 +1229,8 @@ def install_npm_win(env_dir, src_dir, args):
                     join(env_dir, 'bin', 'npm-cli.js'))
         shutil.copytree(join(bin_path, 'node_modules'),
                         join(env_dir, 'bin', 'node_modules'))
-        npm_gh_url = 'https://raw.githubusercontent.com/npm/cli'
-        npm_bin_url = '{}/{}/bin/npm'.format(npm_gh_url, args.npm)
-        writefile(join(env_dir, 'bin', 'npm'), urlopen(npm_bin_url).read())
+        shutil.copy(join(src_dir, npm_ver, 'bin', 'npm'),
+                    join(env_dir, 'bin', 'npm'))
 
 
 def _read_packages(filenames):