chore(release): publish a Docker image, plus final review fixes - #81
chore(release): publish a Docker image, plus final review fixes#81ekalinin wants to merge 9 commits into
Conversation
49572f3 to
db7cdf2
Compare
|
Force-pushed after the review. The mixed-input finding is fixed differently than the first attempt: The previous version turned the path prefix off for the whole run when Verified against the live API: Also here: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 83.61% 83.64% +0.03%
==========================================
Files 35 35
Lines 946 954 +8
==========================================
+ Hits 791 798 +7
- Misses 100 101 +1
Partials 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Stacked on #80. Review that one first. This is the last PR of the stack and also carries the fixes from the final whole-branch review.
What changed
Docker image. A
gcr.io/distroless/static:nonrootimage built by GoReleaser and pushed toghcr.io/ekalinin/github-markdown-toc.gofor linux/amd64 and linux/arm64. Authenticated with the workflow's built-inGITHUB_TOKEN, so no new repository secret. Distroless rather than barescratchbecause every run callshttps://api.github.comand needs a CA bundle.Fixes from the final review of the whole stack:
CHANGELOG.mdrecords the whole parity effort under[Unreleased]. Its previous claim that output is "byte-identical to 2.0.1" stopped being true once multi-document runs began prefixing links.--insertnow requires at least one file path. Combined with STDIN it used to fail with "no markers found", or, if the piped content had markers, report success about an already-deleted temp file and leave an orphan backup inTMPDIR.--insert docs/*.mdfrom a repo root wrote links intodocs/a.mdthat resolved todocs/docs/a.md.WriteAtomicand the backup follow symlinks instead of replacing them.--inserton a symlinkedREADME.mdused to replace the link with a regular file and leave the real document untouched.make release-local-nodockerfor validating a release without a Docker daemon.token-configured=falsefor a run authenticated bytoken.txt; the backup-collision error says it is refusing to overwrite; README corrections for the release tag,token.txt, and running the image with--user.Compatibility
make release-localnow needs a running Docker daemon, because the snapshot build includes the images. Usemake release-local-nodockerwhen that is not available.Validation
The image build itself has not been exercised locally - no Docker daemon was available - so the first real test is the next tag push.