fix: resolve 6 bugs — password hashing, SQL injection risk, JWT inconsistency, and count query params#8
Merged
Conversation
…sistency, and count query params - app/api/users/route.ts: hash passwords with bcrypt before storing; fix count query sending wrong params when no search filter is active (passed `[limit]` to a parameterless SQL statement, causing a better-sqlite3 error) - app/api/users/[id]/route.ts: hash password with bcrypt on user update - app/api/sessions/[id]/route.ts: replace double-quoted SQL string literal with a parameterised binding (SQLite treats double-quotes as identifiers) - app/api/client/login/route.ts: replace inconsistent raw JWT_SECRET check (min 64 chars) with getJwtSecret() so client and admin tokens share the same secret derivation logic - lib/db.ts: catch and log startup validateConnection() errors instead of silently dropping them https://claude.ai/code/session_01DkUApogQMjHvzsmsEty9z7
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count query sending wrong params when no search filter is active (passed
[limit]to a parameterless SQL statement, causing a better-sqlite3 error)with a parameterised binding (SQLite treats double-quotes as identifiers)
(min 64 chars) with getJwtSecret() so client and admin tokens share the
same secret derivation logic
silently dropping them
https://claude.ai/code/session_01DkUApogQMjHvzsmsEty9z7