fix: handle unanimous vote display for first proposal (#184)#233
Open
mkcash wants to merge 2 commits into
Open
fix: handle unanimous vote display for first proposal (#184)#233mkcash wants to merge 2 commits into
mkcash wants to merge 2 commits into
Conversation
added 2 commits
May 27, 2026 11:53
Signed-off-by: mkcash <mkcashcom@gmail.com>
Bug: First proposal (effectai#1) had a unanimous vote (all YES), but the vote result icon showed 'empty' instead of 'passed'. The code assumed both YES (index 1) and NO (index 2) vote counts always existed. Changes: - Proposals.vue: New hasMoreYesVotes/hasMoreNoVotes methods that handle missing vote types (single-option unanimous votes) - _id/index.vue: votePercentage now safely handles missing vote_counts indices with null-safe fallback to 0 Fixes effectai#184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184
Problem
Proposal #1 had a unanimous vote (all YES), but the proposal list showed an empty vote icon.
Changes
Testing
Unanimous votes now show correct arrow direction