Draft
Conversation
MoisesGSalas
force-pushed
the
mgs/add-additional-default-ingress
branch
2 times, most recently
from
e3b26e9 to
d751443
Compare
Both services expose a public API and should come with an ingress by default. Previously you would have use the `DRYDOCK_INGRESS_EXTRA_HOSTS` setting in order to create the additional ingress objects.
Member
|
The changes proposed in this PR were included in the Teak release of the plugin; however, we didn't apply the backport to Sumac. @MoisesGSalas, could you please change the target branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both services expose a public API and should come with an ingress by default. Previously you would have use the
DRYDOCK_INGRESS_EXTRA_HOSTSsetting in order to create the additional ingress objects.This changes are mostly cherry-picked from #163, and should also be included in the sumac release