fix(ui): remove blocks holder listeners and detach it on destroy#174
Open
SAY-5 wants to merge 1 commit into
Open
fix(ui): remove blocks holder listeners and detach it on destroy#174SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #170
BlocksUIattachesbeforeinputandkeydownlisteners to the blocks holder in#prepareBlocksHolder()butdestroy()never removes them, and the holder itself is never detached. If a holder is reused or a new instance is created, the old listeners keep firing alongside the new ones (duplicateBeforeInputUIEventdispatches and stale undo/redo handling).This wires both listeners to a single
AbortControllerand calls.abort()indestroy(), which is the pattern the issue suggested.destroy()now also detaches#blocksHolder, andEditorjsUI.destroy()(previously a no-op) removes its#editorWrapperso the whole subtree comes off the page.The
uipackage has no test runner wired up yet (noBlocks.spec.tsand notestscript), so this doesn't add a spec. Happy to follow up with one if you want the test harness set up here.