Fix stop/restart hanging when ECA server is unresponsive#20
Draft
Fix stop/restart hanging when ECA server is unresponsive#20
Conversation
The stop() method awaited a shutdown JSON-RPC request with no timeout and never forcefully killed the child process. When ECA was stuck (e.g. during MCP initialization retries with 401 errors), stop() would hang forever, leaving the user unable to stop or restart from the UI. - Add timeout (5s) on the graceful shutdown request - Add killProcess() with SIGTERM → SIGKILL escalation - Always clean up process/connection refs and update status in finally - Guard against missing connection (stuck in Starting state) 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca <noreply@eca.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stop() method awaited a shutdown JSON-RPC request with no timeout and never forcefully killed the child process. When ECA was stuck (e.g. during MCP initialization retries with 401 errors), stop() would hang forever, leaving the user unable to stop or restart from the UI.
🤖 Generated with eca