upstream: finish and cache requests even when the client cancels - #4
Open
charludo wants to merge 1 commit into
Open
upstream: finish and cache requests even when the client cancels#4charludo wants to merge 1 commit into
charludo wants to merge 1 commit into
Conversation
charludo
force-pushed
the
ch/fix-context-cancelable-by-client
branch
from
August 27, 2026 09:12
1b14bb0 to
19a00db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the client canceling (in our concrete case, due to an intentionally short timeout), the context cancellation would also cancel the proxy's upstream request, thus also not caching the response.
With this change, we now finish the upstream request even after a client cancels its request, so the next client request can be answered from cache.