Repository navigation
Fix C++-generating back end issue with inaccessible or out-of-scope template arguments - #192
Closed
wchilders-nvidia wants to merge 1 commit into
Closed
wchilders-nvidia wants to merge 1 commit into
wchilders-nvidia wants to merge 1 commit into
Conversation
mborland
approved these changes
Oct 1, 2026
mborland
left a comment
Contributor
There was a problem hiding this comment.
The one suggestion is a nitpick more than anything. Looks good to me.
wchilders-nvidia
force-pushed
the
fix/191
branch
from
October 1, 2026 21:06
fe7f998 to
57dc7ef
Compare
Collaborator
Author
|
The failures seem legitimate, this was submitted by EDG as a late patch for inclusion in the project. It'll need additional work to prevent regressions, e.g. (in |
…emplate arguments [GH #191]
wchilders-nvidia
force-pushed
the
fix/191
branch
from
October 5, 2026 16:08
1a5aa43 to
e7e4864
Compare
|
Merged as a63fc0e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #191 and additionally relaxes the accepted regex (used to identify patch numbers for commits) by the pre-push hook in line with the suggested "[GH #XYZ]" in #164.