Repository navigation
CWG 2355 Deducing noexcept-specifiers - #162
cpplearner wants to merge 6 commits into
Conversation
|
Testing output looks like all improvements so far; we should be able to further verify and take care of updating the expected recordings if you're not able to. |
|
The change looks good to me. Personal tests were okay (will need to update some). |
|
I went ahead and gave this an issue tracking number: #197 |
|
Me, earlier:
I take that back: MSVC didn't implement that until very recently. So rather than removing the condition completely, make it dependent on Wyatt:
Thanks! @cpplearner : Use that number for your Changes entry. It' might look something like: P.S.: Thanks for that contribution, @cpplearner — it may well turn out to be the first outside contribution to this project! |
|
|
Please add tests that show the change in the relevant configurations, i.e. GCC/Clang/Microsoft 19.50/Microsoft 19.51/standard mode for both C++14 and C++17. Probably just use tests/tests/cwg/2355a.sft.cpp with |
| 10/1/26 [GH #197] | ||
| Deducing noexcept-specifiers | ||
|
|
||
| Previously, the front end emulated Clang and GCC's ability to deduce simple dependent |
There was a problem hiding this comment.
lines should wrap at column 79 (there should be a git hook pointing that out)
|
|
Looks good to me — thanks! |
|
Merge with f0e30b6 |
The functionality has already been implemented (for g++ mode) in d86293c. This PR simply removes the flag to make it work in all modes.