Skip to content

dev-init: [] fix direnv discovery messages - #161

Closed
carsonRadtke wants to merge 1 commit into
edgcpp:mainfrom
carsonRadtke:dev-init-fix-direnv-check
Closed

carsonRadtke wants to merge 1 commit into
edgcpp:mainfrom
carsonRadtke:dev-init-fix-direnv-check

Conversation

@carsonRadtke

Copy link
Copy Markdown
Contributor

The conditional for checking whether or not direnv exists on the user's machine was backwards. This PR fixes the check so the error message is appropriate.


CONTRIBUTING.md checklist:

  • There is an open issue your pull request addresses.
  • Your commits are tagged with the issue number they're addressing (i.e., [GH #12345]).
  • You understand your code:
  • You've explained the high level details of your design.
  • You've noted alternative designs you considered (particularly if diverging from an agreed upon design).
  • Your code doesn't result in a major (negative) change in compiler performance or memory consumption.
  • Your code changes are reasonably localized and do not affect unrelated components (major refactors -- AI or not -- will be accepted ONLY from established contributors or by working closely with the relevant maintainer(s)).
  • You've put effort into maintaining code quality:
  • Your code is formatted in "EDG Style".
  • Your code has good comments.
  • Your code has a Changes entry (not needed for dev_tools or build system changes).
  • You used edg-docker-test:
  • You have added tests (or there are existing tests) that FAIL before your change but PASS after your change.
  • You do not see regressions and have carefully reviewed changes in recorded outputs with edg-test-run-diff (or a similar tool).
  • You've updated the default recordings after reviewing differences with edg-docker-test -W.

@DarkArc

DarkArc commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Merged as 158320e with an additional fix for a related inverted condition. Thanks!

@DarkArc DarkArc closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants