feat(control): add vNUMA placement fields to ZoneVirtualizationOptionsSpec#29
Draft
tycho wants to merge 1 commit into
Draft
feat(control): add vNUMA placement fields to ZoneVirtualizationOptionsSpec#29tycho wants to merge 1 commit into
tycho wants to merge 1 commit into
Conversation
…sSpec Add numa_nodes (uint32, 0 = auto) and numa_strategy (NumaStrategy enum with UNSPECIFIED/COMPACT/SCATTER) to ZoneVirtualizationOptionsSpec, plus the NumaStrategy enum itself. These plumb customer intent for explicit vNUMA node count and node-selection strategy through to placement. Defaults preserve existing behavior: numa_nodes=0 yields the legacy vCPU-coverage-driven placement, and UNSPECIFIED is treated as COMPACT (nearest-SLIT-distance expansion). No consumers yet; subsequent commits in the protect repo wire these through CRI annotations, the protect-ctl CLI, daemon validation, and the placement algorithm. Signed-off-by: Steven Noonan <steven@edera.dev>
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add numa_nodes (uint32, 0 = auto) and numa_strategy (NumaStrategy enum with UNSPECIFIED/COMPACT/SCATTER) to ZoneVirtualizationOptionsSpec, plus the NumaStrategy enum itself. These plumb customer intent for explicit vNUMA node count and node-selection strategy through to placement.
Defaults preserve existing behavior: numa_nodes=0 yields the legacy vCPU-coverage-driven placement, and UNSPECIFIED is treated as COMPACT (nearest-SLIT-distance expansion).
No consumers yet; subsequent commits in the protect repo wire these through CRI annotations, the protect-ctl CLI, daemon validation, and the placement algorithm.