Skip to content

Fix: Executor overwrites Earthmover errors when using fallback encoding#31

Open
johncmerfeld wants to merge 1 commit intodevelopmentfrom
fix/misleading-codec-error
Open

Fix: Executor overwrites Earthmover errors when using fallback encoding#31
johncmerfeld wants to merge 1 commit intodevelopmentfrom
fix/misleading-codec-error

Conversation

@johncmerfeld
Copy link
Collaborator

Sometimes this happens:

  • Input file has a bonkers encoding and is the wrong file
  • First earthmover run fails to decode
  • Retry earthmover with latin1, which is pretty much guaranteed to decode
  • Second earthmover run fails because of the other problem (extra header, missing column, etc)
  • We wrongly log the error as the initial encoding error

Doesn't display much incorrect in the main UI but does result in an incorrect stacktrace sent to the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant