Trigger executor image build when the bundles repo is updated#28
Open
johncmerfeld wants to merge 3 commits intodevelopmentfrom
Open
Trigger executor image build when the bundles repo is updated#28johncmerfeld wants to merge 3 commits intodevelopmentfrom
johncmerfeld wants to merge 3 commits intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployed Runway has a dependence on Github, from which we have recently inherited downtime. We require that Github is responsive at the time of a job run. This is because the executor image might be stale to new changes in the bundles repo, and so performs a
git pullto ensure it's running the most up-to-date bundle.We can remove this dependence from the executor by triggering a rebuild of the executor image whenever there is a merge to main in the bundles repo. It still attempts to
git pullbut a failure there is no longer fatal.There is also an app-side dependence that we can address separately.
If we like this, I think there's just two actions to take in AWS to get it up and running.