Support extended keepalive parameters in epoll and io_uring#6089
Support extended keepalive parameters in epoll and io_uring#6089ivu-mawi wants to merge 4 commits into
Conversation
|
I am wondering for the new config to potentially have an Option object to be more extensible than what we have now. |
|
@ivu-mawi I have introduced generic TCP option, can you rebase on master |
|
that only affects the new config |
|
Seems good! I'll gladly rebase when I get the chance, which will be next week only I'm afraid. |
|
No problem @ivu-mawi . Thank you! |
9a4a2f0 to
fd5a51c
Compare
|
why is that PR still in draft mode ? |
|
I'm trying to verify locally that it actually works. But I can't seem to get packet capturing to work in WSL (Windows subsystem for linux), and that's the only Linux I have access to at the moment. :( I'll give up the test. Code is ready, I'll mark it ready. |
|
@ivu-mawi an you rebase on latest branch to resolve the git conflict ? |
b400750 to
757c83f
Compare
|
Fixed unit tests by disallowing |
1ab7c76 to
caa0f8c
Compare
|
One thing I'm not sure about with the new TcpOption is we're setting various parameters to |
|
Oh, it looks like exactly that is actually causing an error in the pipeline runs. |
… option to something < 1, since this is at best useless and at worst leads to an error.
|
We can see here that Linux does not allow any value < 1. I have made it so that I've done that just because it's nicer to have a |
EpollTransport: support extended keepalive parameters TCP_KEEPIDLE, TCP_KEEPCNT and TCP_KEEPINTVL
Builds on #5183. This work has not made it into master, so I'm catching up on that.
I hope I've ported it correctly given the refactoring of the TCPSSLOptions / TCPConfig.
For motivation, see #5163 and #5183 and #5970