Skip to content

tmf.ui.swtbot.tests: Modify button name to make the test work#405

Open
arfio wants to merge 1 commit into
eclipse-tracecompass:masterfrom
arfio:releng-rc1-fix
Open

tmf.ui.swtbot.tests: Modify button name to make the test work#405
arfio wants to merge 1 commit into
eclipse-tracecompass:masterfrom
arfio:releng-rc1-fix

Conversation

@arfio
Copy link
Copy Markdown
Contributor

@arfio arfio commented May 30, 2026

What it does

tmf.ui.swtbot.tests: Modify button name to make the test work with the interface change

How to test

Run the tests

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Summary by CodeRabbit

  • Tests
    • Updated test dialog interactions to align with current UI button labeling.

Review Change Stack

Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2dae25d1-f169-4c16-b9e5-9d89ec17f080

📥 Commits

Reviewing files that changed from the base of the PR and between 1c6b215 and 664b774.

📒 Files selected for processing (1)
  • tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/project/AddProjectNatureTest.java

📝 Walkthrough

Walkthrough

This PR updates SWTBot test UI dialog controls to use an APPLY button label instead of OK. The toggleFilters helper method now clicks the APPLY button to confirm filter dialogs through a new string constant.

Changes

Filter Dialog Button Update

Layer / File(s) Summary
Apply button constant and usage
tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/project/AddProjectNatureTest.java
New APPLY_BUTTON constant added at line 93, and the toggleFilters method updated at line 252 to click the APPLY button instead of OK when confirming filter dialogs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A button renamed, a path made straight,
From OK to APPLY, no more to wait,
In tests we hop and click with care,
Dialog dialogs answered fair! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: modifying a button name (from OK to APPLY) in tmf.ui.swtbot.tests to fix a test.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant