Skip to content

[2391] Add support of inheritance of actor in actors compartment - #2394

Merged
AxelRICHARD merged 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/enh/support_inheritance_in_actors_compartment
Aug 10, 2026
Merged

[2391] Add support of inheritance of actor in actors compartment#2394
AxelRICHARD merged 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/enh/support_inheritance_in_actors_compartment

Conversation

@jerome-obeo

@jerome-obeo jerome-obeo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Add support of inheritance of actor in actors compartment of CaseDefinition and CaseUsage graphical nodes
The actors compartment is also visible in the following graphical nodes:

  • RequirementDefinition
  • RequireUsage
  • ConcernDefinition
  • ConcernUsage
  • SatisfyRequirementUsage

Bug: #2391

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@jerome-obeo
jerome-obeo force-pushed the jgo/enh/support_inheritance_in_actors_compartment branch 3 times, most recently from d754d51 to 689d3aa Compare August 5, 2026 15:23
@AxelRICHARD AxelRICHARD added this to the 2026.9.0 milestone Aug 5, 2026
@jerome-obeo
jerome-obeo force-pushed the jgo/enh/support_inheritance_in_actors_compartment branch 8 times, most recently from 25ad7dd to 8feeb6d Compare August 7, 2026 10:02
Comment thread doc/content/modules/user-manual/pages/release-notes/2026.9.0.adoc Outdated
Comment thread doc/content/modules/user-manual/pages/release-notes/2026.9.0.adoc Outdated
compartmentNodeDescriptionProviders.add(new InheritedCompartmentItemNodeDescriptionProvider(SysmlPackage.eINSTANCE.getConcernDefinition(), SysmlPackage.eINSTANCE.getRequirementDefinition_ActorParameter(), colorProvider, this.getDescriptionNameGenerator()));
compartmentNodeDescriptionProviders.add(new InheritedCompartmentItemNodeDescriptionProvider(SysmlPackage.eINSTANCE.getConcernUsage(), SysmlPackage.eINSTANCE.getRequirementUsage_ActorParameter(), colorProvider, this.getDescriptionNameGenerator()));
compartmentNodeDescriptionProviders.add(new InheritedCompartmentItemNodeDescriptionProvider(SysmlPackage.eINSTANCE.getSatisfyRequirementUsage(), SysmlPackage.eINSTANCE.getRequirementUsage_ActorParameter(), colorProvider, this.getDescriptionNameGenerator()));
// As far as RequirementUsage and RequirementDefinition are concerned, inherited item node descriptions are created by createCompartmentsForListItems method

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment makes me feel we do something wrong here.
It seems strange to have several way of instantiation for inherited item node descriptions.
Please take the time to check if they could/should be instantiated the same way for every inherited item node descriptions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, actors compartment node provider for RequirementDefinition and RequirementUsage was made twice (as the item node provider):

  • a first time explicitly in actors compartments creation method with a dedicated provider (handling custom label for compartment name).
  • a second time in compartments general creation method (createCompartmentsForListItems) because actorParameter reference was in global map COMPARTMENTS_WITH_LIST_ITEMS with a generic code.

The second provider was never read due to cache provider retrieval method that only returns the first node provider with a given name.
I decided to remove the references SysmlPackage.eINSTANCE.getRequirementUsage_ActorParameter() and SysmlPackage.eINSTANCE.getRequirementDefinition_ActorParameter() from the global map COMPARTMENTS_WITH_LIST_ITEMS.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it seems fair. Please be sure that it does not broke anything else. We want to still be able to view those compartments, and be able to create/delete/edit actors inside them.

@AxelRICHARD AxelRICHARD changed the title [2391] Add support of inheritance of actor in _actors_ compartment [2391] Add support of inheritance of actor in actors compartment Aug 10, 2026
Add support of inheritance of actor in actors compartment of
CaseDefinition and CaseUsage graphical nodes
The actors compartment is also visible in the following graphical
nodes:

- RequirementDefinition
- RequireUsage
- ConcernDefinition
- ConcernUsage
- SatisfyRequirementUsage

Bug: eclipse-syson#2391
Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
@jerome-obeo
jerome-obeo force-pushed the jgo/enh/support_inheritance_in_actors_compartment branch from 8feeb6d to 81a7fb4 Compare August 10, 2026 13:41
@AxelRICHARD
AxelRICHARD merged commit 26133b5 into eclipse-syson:main Aug 10, 2026
3 checks passed
@jerome-obeo
jerome-obeo deleted the jgo/enh/support_inheritance_in_actors_compartment branch August 10, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support of inheritance of actor in actors compartment of CaseDefinition and CaseUsage graphical nodes

2 participants