[2391] Add support of inheritance of actor in actors compartment - #2394
Conversation
d754d51 to
689d3aa
Compare
25ad7dd to
8feeb6d
Compare
| compartmentNodeDescriptionProviders.add(new InheritedCompartmentItemNodeDescriptionProvider(SysmlPackage.eINSTANCE.getConcernDefinition(), SysmlPackage.eINSTANCE.getRequirementDefinition_ActorParameter(), colorProvider, this.getDescriptionNameGenerator())); | ||
| compartmentNodeDescriptionProviders.add(new InheritedCompartmentItemNodeDescriptionProvider(SysmlPackage.eINSTANCE.getConcernUsage(), SysmlPackage.eINSTANCE.getRequirementUsage_ActorParameter(), colorProvider, this.getDescriptionNameGenerator())); | ||
| compartmentNodeDescriptionProviders.add(new InheritedCompartmentItemNodeDescriptionProvider(SysmlPackage.eINSTANCE.getSatisfyRequirementUsage(), SysmlPackage.eINSTANCE.getRequirementUsage_ActorParameter(), colorProvider, this.getDescriptionNameGenerator())); | ||
| // As far as RequirementUsage and RequirementDefinition are concerned, inherited item node descriptions are created by createCompartmentsForListItems method |
There was a problem hiding this comment.
This comment makes me feel we do something wrong here.
It seems strange to have several way of instantiation for inherited item node descriptions.
Please take the time to check if they could/should be instantiated the same way for every inherited item node descriptions.
There was a problem hiding this comment.
Actually, actors compartment node provider for RequirementDefinition and RequirementUsage was made twice (as the item node provider):
- a first time explicitly in actors compartments creation method with a dedicated provider (handling custom label for compartment name).
- a second time in compartments general creation method (
createCompartmentsForListItems) because actorParameter reference was in global mapCOMPARTMENTS_WITH_LIST_ITEMSwith a generic code.
The second provider was never read due to cache provider retrieval method that only returns the first node provider with a given name.
I decided to remove the references SysmlPackage.eINSTANCE.getRequirementUsage_ActorParameter() and SysmlPackage.eINSTANCE.getRequirementDefinition_ActorParameter() from the global map COMPARTMENTS_WITH_LIST_ITEMS.
There was a problem hiding this comment.
Ok it seems fair. Please be sure that it does not broke anything else. We want to still be able to view those compartments, and be able to create/delete/edit actors inside them.
Add support of inheritance of actor in actors compartment of CaseDefinition and CaseUsage graphical nodes The actors compartment is also visible in the following graphical nodes: - RequirementDefinition - RequireUsage - ConcernDefinition - ConcernUsage - SatisfyRequirementUsage Bug: eclipse-syson#2391 Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
8feeb6d to
81a7fb4
Compare
Add support of inheritance of actor in actors compartment of CaseDefinition and CaseUsage graphical nodes
The actors compartment is also visible in the following graphical nodes:
RequirementDefinitionRequireUsageConcernDefinitionConcernUsageSatisfyRequirementUsageBug: #2391
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests