Skip to content

fix audit findings action_78, action_66, action_68#617

Merged
masc2023 merged 9 commits intomainfrom
masc2023_fix_audit_findings
Apr 1, 2026
Merged

fix audit findings action_78, action_66, action_68#617
masc2023 merged 9 commits intomainfrom
masc2023_fix_audit_findings

Conversation

@masc2023
Copy link
Copy Markdown
Contributor

@masc2023 masc2023 commented Mar 21, 2026

Action_78: It shall be defined who evaluates and accepts/ rejects Change Requests for Feature Changes and for Component Changes.

Action_66: Elaborate, what is a topic and what happens if a critical topic is not accepted.

Action_68: The version in which the Safety Anomaly was detected is covered, but the version which are based on the faulty version needs to be identified too.

Resolves: #567

Resolves partly: #557

Depends on #619, so Merge this PR after #619 is merged

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments fixed but issue still in draft

aschemmel-tech
aschemmel-tech previously approved these changes Mar 25, 2026
@masc2023 masc2023 marked this pull request as ready for review March 26, 2026 07:20
@masc2023 masc2023 requested a review from aschemmel-tech March 26, 2026 07:25
@masc2023 masc2023 changed the title fix audit findings action_78 fix audit findings action_78, action_66 Mar 30, 2026
@masc2023 masc2023 changed the title fix audit findings action_78, action_66 fix audit findings action_78, action_66, action_68 Mar 30, 2026
@masc2023 masc2023 force-pushed the masc2023_fix_audit_findings branch from 23b9aba to 8a95708 Compare March 31, 2026 10:13
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reformulated, as now there are more versions to report in the template (First/Last Affected Release) - to clearly solve Action_68

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New formulation is "Document the first version where the problem was detected and the last affected version." - which is a bit misleading, because there can be a new bug found (in the field) which is present not only in the release where it was found but also in previous (and possibly later) releases.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@masc2023 masc2023 force-pushed the masc2023_fix_audit_findings branch from 8a95708 to e0976f2 Compare April 1, 2026 07:36
Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partly fixed but two comments (one on old finding) added

Copy link
Copy Markdown
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all findings resolved

@masc2023 masc2023 merged commit 71e9f12 into main Apr 1, 2026
5 checks passed
@masc2023 masc2023 deleted the masc2023_fix_audit_findings branch April 1, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Change Mgt Audit findings

2 participants