fix(rust): E0716 extend log metadata lifetimes during formatting - #304
Open
ian-harmon-traton wants to merge 3 commits into
Open
ian-harmon-traton wants to merge 3 commits into
ian-harmon-traton wants to merge 3 commits into
Conversation
Use score_baselibs' VLAN target when the local VLAN implementation is disabled. This makes score/network/vlan.h available in Bazel's compile sandbox.
This reverts commit c68f05a.
Bind module, file, and line metadata before passing them to score_write! to prevent E0716 temporary-value lifetime errors.
ian-harmon-traton
requested a deployment
to
workflow-approval
September 9, 2026 18:48 — with
GitHub Actions
Waiting
ian-harmon-traton
requested a deployment
to
workflow-approval
September 9, 2026 18:48 — with
GitHub Actions
Waiting
ian-harmon-traton
requested a deployment
to
workflow-approval
September 9, 2026 18:48 — with
GitHub Actions
Waiting
ian-harmon-traton
requested a deployment
to
workflow-approval
September 9, 2026 18:48 — with
GitHub Actions
Waiting
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
pawelrutkaq
reviewed
Sep 10, 2026
pawelrutkaq
left a comment
Contributor
There was a problem hiding this comment.
please check with 1.91 + toolchain feroceen
Author
will test next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Issue
Fixes the following Rust compilation error in
score_log_bridge:The same error occurs for record.file() and record.line().
Reproduce it by building a Rust target that depends on
score_log_bridgeThe compiler reported E0716 for Record::module_path(), Record::file(), and Record::line().
What Changed
The metadata values are now assigned to local variables before being passed to score_write!. This extends their lifetimes through the formatting operation without changing the generated log output.
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #