hmon: add C++ interface to logic monitor by arkjedrz · Pull Request #98 · eclipse-score/lifecycle

arkjedrz · 2026-03-02T10:34:20Z

Add C++ interface to logic monitor.

Resolves #16

github-actions · 2026-03-02T10:35:04Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: cddde3cb-fb2f-4a31-8ad0-76843e67ced2
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (71 packages loaded, 9 targets configured)

Analyzing: target //:license-check (128 packages loaded, 390 targets configured)

Analyzing: target //:license-check (153 packages loaded, 3442 targets configured)

Analyzing: target //:license-check (154 packages loaded, 5266 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7769 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9789 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9913 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 10039 targets configured).
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.132s, Critical Path: 2.54s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-03-02T10:38:48Z

The created documentation from the pull request is available at: docu-html

Copilot

Pull request overview

This PR extends the health monitoring library with new monitor types (logic + heartbeat) and exposes them through the C++ API/FFI, while refactoring the Rust worker/evaluation plumbing and supervisor client selection to support multiple monitor kinds.

Changes:

Add Rust LogicMonitor + HeartbeatMonitor implementations and integrate them into HealthMonitorBuilder/HealthMonitor (including evaluation + error typing).
Add Rust FFI bindings and C++ wrappers/headers for heartbeat + logic monitors, and update the C++ health monitor API/tests accordingly.
Refactor supervisor API client into a dedicated Rust module with feature-gated implementations and update the worker loop to pass a shared starting point into monitor evaluation.

Reviewed changes

Copilot reviewed 29 out of 30 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/health_monitoring_lib/rust/worker.rs	Refactors evaluation loop for new error variants and passes `hmon_starting_point` into monitor evaluation; moves supervisor client trait out.
src/health_monitoring_lib/rust/tag.rs	Adds `StateTag` newtype for logic monitor state tagging and updates tag tests.
src/health_monitoring_lib/rust/supervisor_api_client/mod.rs	Introduces shared `SupervisorAPIClient` trait and feature-gated implementation modules.
src/health_monitoring_lib/rust/supervisor_api_client/stub_supervisor_api_client.rs	Adds stub supervisor client implementation.
src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs	Adds score supervisor client implementation (monitor_rs-based).
src/health_monitoring_lib/rust/logic/mod.rs	Adds logic monitor module exports and FFI module.
src/health_monitoring_lib/rust/logic/logic_monitor.rs	Implements `LogicMonitor`, builder, evaluation, and unit tests.
src/health_monitoring_lib/rust/logic/ffi.rs	Adds FFI API + tests for logic monitor builder/monitor operations.
src/health_monitoring_lib/rust/lib.rs	Integrates deadline/heartbeat/logic monitors into builder/health monitor, adds `HealthMonitorError`, and changes `build()`/`start()` to return `Result`.
src/health_monitoring_lib/rust/heartbeat/mod.rs	Adds heartbeat monitor module exports and FFI module.
src/health_monitoring_lib/rust/heartbeat/heartbeat_state.rs	Adds atomic packed heartbeat state representation + tests (incl. loom gating).
src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs	Implements `HeartbeatMonitor`, builder validation, evaluation logic, and extensive tests (incl. loom).
src/health_monitoring_lib/rust/heartbeat/ffi.rs	Adds FFI API + tests for heartbeat monitor builder and heartbeat calls.
src/health_monitoring_lib/rust/ffi.rs	Extends core FFI surface to add heartbeat/logic monitor support and map `HealthMonitorError` to `FFICode`.
src/health_monitoring_lib/rust/deadline/mod.rs	Re-exports `DeadlineEvaluationError` for typed evaluation errors.
src/health_monitoring_lib/rust/deadline/deadline_monitor.rs	Refactors deadline monitor to use `HasEvalHandle`, typed evaluation errors, and updated evaluator signature.
src/health_monitoring_lib/cpp/tests/health_monitor_test.cpp	Extends C++ integration test to construct/get/use heartbeat and logic monitors.
src/health_monitoring_lib/cpp/logic_monitor.cpp	Adds C++ wrapper implementation for logic monitor builder/monitor.
src/health_monitoring_lib/cpp/include/score/hm/tag.h	Adds default `Tag` ctor and introduces `StateTag`.
src/health_monitoring_lib/cpp/include/score/hm/logic/logic_monitor.h	Adds C++ public API for logic monitor builder/monitor.
src/health_monitoring_lib/cpp/include/score/hm/heartbeat/heartbeat_monitor.h	Adds C++ public API for heartbeat monitor builder/monitor.
src/health_monitoring_lib/cpp/include/score/hm/health_monitor.h	Extends C++ health monitor API to add/get heartbeat and logic monitors.
src/health_monitoring_lib/cpp/heartbeat_monitor.cpp	Adds C++ wrapper implementation for heartbeat monitor builder/monitor.
src/health_monitoring_lib/cpp/health_monitor.cpp	Extends C++ health monitor wrapper to add builder/get APIs for heartbeat + logic monitors.
src/health_monitoring_lib/Cargo.toml	Makes `monitor_rs` optional, adds loom target dep, and updates feature defaults.
src/health_monitoring_lib/BUILD	Adds new C++ sources/headers; adjusts Rust crate feature flags for Bazel targets/tests.
examples/rust_supervised_app/src/main.rs	Updates example to handle new `Result` returns for `build()` and `start()`.
Cargo.toml	Sets workspace default-members and configures `unexpected_cfgs` for `cfg(loom)`.
Cargo.lock	Updates lockfile with new dependencies (loom + transitive crates).

Comments suppressed due to low confidence (1)

src/health_monitoring_lib/cpp/include/score/hm/tag.h:39

Tag stores data_ as const char* const, which makes the pointer itself immutable after construction. Any FFI API that writes a StateTag/Tag into an out-parameter (e.g., a StateTag* passed to Rust) would end up mutating a const subobject, which is undefined behavior in C++. If tags are intended to be written/returned via out-params, change the field to const char* data_ (pointer-to-const data, but not const pointer) so the struct remains trivially writable.

/// Common string-based tag.
class Tag
{
  public:
    /// Create an empty tag.
    Tag() : data_{nullptr}, length_{0} {}

    /// Create a new tag from a C-style string.
    template <size_t N>
    explicit Tag(const char (&tag)[N]) : data_(tag), length_(N - 1)
    {
    }

  private:
    /// SAFETY: This has to be FFI compatible with the Rust side representation.
    const char* const data_;
    size_t length_;
};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/health_monitoring_lib/rust/heartbeat/ffi.rs

src/health_monitoring_lib/cpp/logic_monitor.cpp

src/health_monitoring_lib/rust/lib.rs

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

src/health_monitoring_lib/rust/lib.rs

src/health_monitoring_lib/rust/logic/ffi.rs

src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs

src/health_monitoring_lib/rust/logic/logic_monitor.rs

src/health_monitoring_lib/rust/logic/ffi.rs

src/health_monitoring_lib/cpp/include/score/hm/logic/logic_monitor.h

MaciejKaszynski · 2026-03-05T10:56:37Z

src/health_monitoring_lib/cpp/logic_monitor.cpp

Add unit tests

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/health_monitoring_lib/cpp/include/score/hm/tag.h:39

Tag() initializes data_ to nullptr. On the Rust side, tags are formatted/hashed/compared using slice::from_raw_parts(data, length), which requires a non-null pointer even when length == 0. Introducing default-constructed tags makes it easy to accidentally pass a null pointer over FFI and trigger UB in Rust. Consider defaulting data_ to a valid empty string pointer (""), and if tags are intended to be written by Rust (e.g., as out-params), avoid const on the stored pointer so mutation is well-defined in C++.

    /// Create an empty tag.
    Tag() : data_{nullptr}, length_{0} {}

    /// Create a new tag from a C-style string.
    template <size_t N>
    explicit Tag(const char (&tag)[N]) : data_(tag), length_(N - 1)
    {
    }

  private:
    /// SAFETY: This has to be FFI compatible with the Rust side representation.
    const char* const data_;
    size_t length_;
};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/health_monitoring_lib/cpp/logic_monitor.cpp

src/health_monitoring_lib/rust/ffi.rs

pawelrutkaq · 2026-03-13T08:20:13Z

src/health_monitoring_lib/cpp/include/score/hm/tag.h

 {
  public:
+    /// Create an empty tag.
+    Tag() : data_{nullptr}, length_{0} {}


Replaced with empty state tag in logic_monitor.cpp:84.

src/health_monitoring_lib/rust/logic/ffi.rs

pawelrutkaq · 2026-03-13T09:05:26Z

Look into Copilot issues too @arkjedrz

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/health_monitoring_lib/cpp/include/score/hm/tag.h:71

using Tag::Tag; no longer refers to the direct base class since Tag is now a class template. As written, these derived tags likely won't inherit the constructor (and may fail to compile at call sites like MonitorTag{"..."}). Update the using declarations to reference the actual base specialization (e.g., Tag<MonitorTag>, Tag<DeadlineTag>, Tag<StateTag>).

/// Monitor tag.
class MonitorTag : public Tag<MonitorTag>
{
  public:
    using Tag::Tag;
};

/// Deadline tag.
class DeadlineTag : public Tag<DeadlineTag>
{
  public:
    using Tag::Tag;
};

/// State tag.
class StateTag : public Tag<StateTag>
{
  public:
    using Tag::Tag;
};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/health_monitoring_lib/cpp/include/score/hm/tag.h

src/health_monitoring_lib/cpp/logic_monitor.cpp

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/health_monitoring_lib/cpp/include/score/hm/tag.h

@@ -29,21 +31,40 @@ class Tag
    {
    }

+    bool operator==(const T& other) const noexcept
+    {
+        std::string_view this_sv{data_, length_};
+        std::string_view other_sv{other.data_, other.length_};
+        return this_sv.compare(other_sv) == 0;
+    }
+
+    bool operator!=(const T& other) const noexcept
+    {
+        return !(*this == other);
+    }
+
  private:
    /// SAFETY: This has to be FFI compatible with the Rust side representation.
-    const char* const data_;
+    const char* data_;
    size_t length_;
 };


src/health_monitoring_lib/cpp/include/score/hm/logic/logic_monitor.h

+class LogicMonitor final
+{
+  public:
+    LogicMonitor(const LogicMonitor&) = delete;
+    LogicMonitor& operator=(const LogicMonitor&) = delete;
+
+    LogicMonitor(LogicMonitor&& other) noexcept = default;
+    LogicMonitor& operator=(LogicMonitor&& other) noexcept = default;
+
+    /// Perform transition to a new state.
+    /// On success, current state is returned.
+    score::cpp::expected<StateTag, Error> transition(const StateTag& state);
+
+    /// Current monitor state.
+    score::cpp::expected<StateTag, Error> state();
+


.vscode/settings.json

src/health_monitoring_lib/cpp/tests/health_monitor_test.cpp

Add C++ interface to logic monitor.

arkjedrz requested review from Copilot and pawelrutkaq March 2, 2026 10:34

arkjedrz self-assigned this Mar 2, 2026

arkjedrz temporarily deployed to workflow-approval March 2, 2026 10:34 — with GitHub Actions Inactive

Copilot started reviewing on behalf of arkjedrz March 2, 2026 10:34 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 7d6edc7 to 1df795e Compare March 3, 2026 13:21

arkjedrz temporarily deployed to workflow-approval March 3, 2026 13:21 — with GitHub Actions Inactive

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 1df795e to 9004e33 Compare March 4, 2026 14:52

arkjedrz requested a deployment to workflow-approval March 4, 2026 14:52 — with GitHub Actions Waiting

arkjedrz requested review from HartmannNico and NicolasFussberger and removed request for HartmannNico March 5, 2026 07:58

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 9004e33 to 0ad41b2 Compare March 5, 2026 10:51

arkjedrz requested a deployment to workflow-approval March 5, 2026 10:51 — with GitHub Actions Waiting

arkjedrz marked this pull request as ready for review March 5, 2026 10:51

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 0ad41b2 to 1e7d813 Compare March 5, 2026 11:00

arkjedrz requested a deployment to workflow-approval March 5, 2026 11:00 — with GitHub Actions Waiting

MaciejKaszynski suggested changes Mar 5, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 1e7d813 to 4d935eb Compare March 5, 2026 14:00

arkjedrz requested a deployment to workflow-approval March 5, 2026 14:00 — with GitHub Actions Waiting

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 4d935eb to 96592df Compare March 9, 2026 13:29

arkjedrz had a problem deploying to workflow-approval March 9, 2026 13:29 — with GitHub Actions Error

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 96592df to d8dbe32 Compare March 13, 2026 07:52

arkjedrz temporarily deployed to workflow-approval March 13, 2026 07:52 — with GitHub Actions Inactive

arkjedrz requested a review from Copilot March 13, 2026 08:18

Copilot started reviewing on behalf of arkjedrz March 13, 2026 08:18 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/health_monitoring_lib/cpp/logic_monitor.cpp Show resolved Hide resolved

src/health_monitoring_lib/rust/ffi.rs Outdated Show resolved Hide resolved

pawelrutkaq requested changes Mar 13, 2026

View reviewed changes

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from d8dbe32 to fe4dbfa Compare March 13, 2026 09:41

arkjedrz requested a deployment to workflow-approval March 13, 2026 09:41 — with GitHub Actions Waiting

arkjedrz requested a deployment to workflow-approval March 13, 2026 10:02 — with GitHub Actions Waiting

arkjedrz requested a review from Copilot March 13, 2026 10:02

Copilot started reviewing on behalf of arkjedrz March 13, 2026 10:02 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

src/health_monitoring_lib/cpp/include/score/hm/tag.h Outdated Show resolved Hide resolved

src/health_monitoring_lib/cpp/include/score/hm/tag.h Show resolved Hide resolved

src/health_monitoring_lib/cpp/logic_monitor.cpp Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from 9cd1470 to e218b43 Compare March 13, 2026 10:13

arkjedrz had a problem deploying to workflow-approval March 13, 2026 10:13 — with GitHub Actions Failure

arkjedrz had a problem deploying to workflow-approval March 13, 2026 10:13 — with GitHub Actions Error

arkjedrz requested a review from Copilot March 13, 2026 10:13

Copilot started reviewing on behalf of arkjedrz March 13, 2026 10:13 View session

pawelrutkaq previously approved these changes Mar 13, 2026

View reviewed changes

Copilot AI reviewed Mar 13, 2026

View reviewed changes

hmon: add C++ interface to logic monitor

241480d

Add C++ interface to logic monitor.

arkjedrz dismissed pawelrutkaq’s stale review via 241480d March 13, 2026 10:25

arkjedrz force-pushed the arkjedrz_logic-monitor-cpp branch from e218b43 to 241480d Compare March 13, 2026 10:25

arkjedrz deployed to workflow-approval March 13, 2026 10:25 — with GitHub Actions Active

arkjedrz temporarily deployed to workflow-approval March 13, 2026 10:25 — with GitHub Actions Inactive

pawelrutkaq approved these changes Mar 13, 2026

View reviewed changes

Conversation

arkjedrz commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaciejKaszynski Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

pawelrutkaq Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

arkjedrz Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pawelrutkaq commented Mar 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

arkjedrz commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading