fix(launch_manager): link -lrt for shm_open/shm_unlink - #618
Open
hskang-amelia wants to merge 5 commits into
Open
hskang-amelia wants to merge 5 commits into
hskang-amelia wants to merge 5 commits into
Conversation
(cherry picked from commit 04f2504) Signed-off-by: amelia@ivis.ai <amelia@ivis.ai>
hskang-amelia
requested a deployment
to
workflow-approval
September 9, 2026 02:57 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
September 9, 2026 02:57 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
|
Documentation preview for this pull request is available at: |
cameron-craig-etas
approved these changes
Sep 9, 2026
cameron-craig-etas
left a comment
cameron-craig-etas
left a comment
Contributor
There was a problem hiding this comment.
We could try conditionally linking against librt for glibc versions < 2.34.
But I think that not really necessary, and just complicates the BUILD files.
So the fix looks good from my point of view.
Address review feedback on eclipse-score#618: glibc 2.34 merged librt and libpthread into libc, but the explicit links stay for older glibc versions. Add a comment in the BUILD file so this is not rediscovered later. Signed-off-by: amelia@ivis.ai <amelia@ivis.ai>
hskang-amelia
requested a deployment
to
workflow-approval
September 9, 2026 15:14 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
September 9, 2026 15:14 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
The comment about glibc v2.34 folding libpthread/libdl/libutil/ libanl/librt into libc had a trailing space, which failed the Common PR checks formatting check. Signed-off-by: amelia@ivis.ai <amelia@ivis.ai> Signed-off-by: hskang <amelia@ivis.ai>
hskang-amelia
requested a deployment
to
workflow-approval
September 10, 2026 01:11 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
September 10, 2026 01:11 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Member
|
Hi @hskang-amelia, what is the reason for this pull request being marked as draft? Do you have more changes planned? |
hskang-amelia
marked this pull request as ready for review
September 18, 2026 01:23
hskang-amelia
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 18, 2026 01:23
hskang-amelia
requested a deployment
to
workflow-approval
September 18, 2026 01:24 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
hskang-amelia
requested a deployment
to
workflow-approval
September 18, 2026 01:24 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Contributor
Author
Sorry, I missed this — I wasn't aware I needed to explicitly mark it ready for review. There are no further changes planned, and it's already got an approval, so I've switched it to ready for review. Thanks for the ping! |
danth
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
launch_manager'scc_binaryonly linked-lpthreadon Linux, butprocess_group_manager.cpp/details/process_launcher.cppboth callshm_open/shm_unlink, which live inlibrton glibc < 2.34 (2.34 foldedlibrtintolibc, masking the missing link dependency on newer glibc).Adds
-lrtalongside-lpthreadin the Linuxlinkopts.Related ticket
closes #617