Changing ready condition reqs

[MaciejKaszynski]

Altering requirements in accordance to discussion on https://github.com/orgs/eclipse-score/discussions/2386#discussioncomment-17494192

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 16456a75-9b19-480e-8b26-9be425bcb2ed
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (46 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2073 targets configured)

Analyzing: target //:license-check (155 packages loaded, 6238 targets configured)

Analyzing: target //:license-check (160 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (166 packages loaded, 6352 targets configured)

Analyzing: target //:license-check (171 packages loaded, 11421 targets configured)

Analyzing: target //:license-check (172 packages loaded, 11429 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
[8 / 15] [Prepa] Writing repo mapping manifest for //:license.check.license_check
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 29.879s, Critical Path: 0.28s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[github-actions]

The created documentation from the pull request is available at: docu-html

[danth]

Some suggestions for the requirement titles.

[SimonKozik]

Changes looks OK

[NicolasFussberger]

Do we still need a requirement regarding the timeout for reaching the Ready State?

[MaciejKaszynski]

I don't think we should have requirements for all config options. Also would the Run target activation timeout not result in the same thing?

[NicolasFussberger]

mmh this ready timeout seems like an important concept as this triggers the component recovery action when expired.
The run target activation timeout (not implemented) - when expired - will trigger the run target level recovery action.

I think independent of which config options we have, these two timeout monitoring seem important for the overall functionality.

[SimonKozik]

I'm not sure If I follow the logic here...

AFAIK things are / should behave like this:

• The ready timeout says when to classify a component startup attempt as failed.
• If component fails to start a configured number of times, then Run Target activation is marked as failed.
• If Run Target activation did fail, then Run Target recovery action should be taken.
• Additionally if Run Target fails to activate in a given time frame, then Run Target activation is marked as failed.

I'm not sure where component recovery action could came into play during Run Target activation.