Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
September 18, 2026 10:32
AlexanderLanin
marked this pull request as draft
September 18, 2026 10:36
Contributor
|
Documentation preview for this pull request is available at: |
AlexanderLanin
marked this pull request as ready for review
September 18, 2026 12:20
MaximilianSoerenPollak
approved these changes
Sep 18, 2026
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Talked about in a call and all questions answered.
Looks good
a-zw
deleted the
refactor/sourcelinks-metamodel-env-vars-upstream-pr
branch
September 18, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
External Needs enter the documentation build as Bazel labels. The sandboxed
needs_jsonaction did not pass those labels through the same path as regular documentation builds, and the olddocs_sources/sphinx-collectionspath mixed documentation mounts with Needs inventory handling.The goal is one clear architecture:
score_metamodelhandles external Needs inventories.score_mountshandles documentation source mounts.Sphinx accepts
--definevalues as text, so the CLI sends the labels as JSON. This is only a transport format; the labels are parsed inscore_metamodel, which resolves the corresponding Needs files.Changes
docs()into the sandboxed Needs action throughEXTERNAL_NEEDS_LABELS.needs_jsonandneeds_json_file.config.collectionspath andsphinx-collectionsdependency.mounts_manifest, consumed byscore_mounts.