Skip to content

make satisfied_by mandatory #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonkri wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

make satisfied_by mandatory #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d65ac6d
make satisfied_by mandatory
antonkri Jul 24, 2026
5abedb6
style: trim trailing whitespace in test_options_failure_effect.rst
antonkri Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/extensions/score_metamodel/metamodel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,11 +290,11 @@ needs_types:
# req-Id: tool_req__docs_common_attr_description
content: ^[\s\S]+$
valid_from: ^v(0|[1-9]\d*)\.(0|[1-9]\d*)(\.(0|[1-9]\d*))?$
mandatory_links:
satisfied_by: feat
optional_links:
# req-Id: tool_req__docs_req_link_satisfies_allowed
derived_from: stkh_req
belongs_to: feat # for evaluation
satisfied_by: feat # new preferred name for belongs_to
# req-Id: tool_req__docs_req_link_covers_aou
covers: aou_req
optional_options:
Expand Down Expand Up @@ -322,12 +322,11 @@ needs_types:
status: ^(valid|invalid)$
# req-Id: tool_req__docs_common_attr_description
content: ^[\s\S]+$
mandatory_links:
satisfied_by: comp
optional_links:
# req-Id: tool_req__docs_req_link_satisfies_allowed
derived_from: feat_req
belongs_to: comp # for backward compatibility
satisfied_by: comp # new preferred name for belongs_to
# TODO: make satisfied_by mandatory once downstream repos migrate from belongs_to
# req-Id: tool_req__docs_req_link_covers_aou
covers: aou_req
optional_options:
Expand Down
2 changes: 1 addition & 1 deletion src/extensions/score_metamodel/tests/rst/options/test_options_failure_effect.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
.. feat_saf_fmea:: Empty failure_effect
:id: feat_saf_fmea__test__empty_failure_effect
:fault_id: FMEA_05
:failure_effect:
:failure_effect:
:sufficient: yes
:status: valid
:expect: feat_saf_fmea__test__empty_failure_effect: is missing required attribute: `failure_effect`.
Expand Down
1 change: 1 addition & 0 deletions src/extensions/score_metamodel/tests/rst/options/test_options_options.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
.. feat_req:: Child requirement
:id: feat_req__abcg
:derived_from: stkh_req__abcd
:satisfied_by: feat__abcg
:expect_not: feat_req__abcg: is missing required link

.. stkh_req:: Parent requirement
Expand Down
Loading