Conversation
FScholPer
changed the title
FScholPer
changed the title
FScholPer
changed the title
lurtz
reviewed
Sep 17, 2026
| workflow_dispatch: {} | ||
| jobs: | ||
| maintenance: | ||
| uses: eclipse-score/cicd-workflows/.github/workflows/daily.yml@cache |
Contributor
There was a problem hiding this comment.
why do you reference a branch and not a fixed revision?
There was a problem hiding this comment.
🟡 Changes recommended
Critical workflow security issues and Renovate scheduling/configuration issues must be resolved before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates APM to 0.30.0 and OpenCode to 1.18.31, while adding Renovate maintenance automation.
Changes:
- Updates lockfiles, checksums, documentation, and DevContainer versions.
- Adds daily maintenance and Renovate configuration.
File summaries
| File | Summary |
|---|---|
tools/README.md |
Updates documented tool versions. |
tools/lockfiles/opencode.lock.json |
Updates OpenCode artifacts and checksums. |
tools/lockfiles/apm.lock.json |
Updates APM artifacts and checksums. |
src/s-core-devcontainer/.devcontainer/s-core-local/versions.yaml |
Updates installed tool versions. |
.github/workflows/daily.yml |
Adds maintenance and Renovate execution. |
.github/renovate.json5 |
Configures Renovate dependency discovery and scheduling. |
Review details
Suppressed comments (3)
.github/renovate.json5:58
- This pattern has no
currentValuecapture, so Renovate can update the standalone version field but cannot rewrite thev...segment in the download URLs. The separate digest pattern is also not tied to each URL, leaving a future update with stale artifact URLs or checksums. Capture the version and adjacent digest together so all platform artifacts are updated atomically.
"\"url\":\\s*\"https://github\\.com/anomalyco/opencode/releases/download/v[^/]+/[^\"]+\"",
"\"sha256\":\\s*\"(?<currentDigest>[^\"]+)\""
.github/renovate.json5:18
config:baseleaves Renovate's default managers enabled, including GitHub Actions, while.github/dependabot.ymlalready updates GitHub Actions, Docker, and devcontainers. Both bots can therefore open overlapping dependency PRs; either limit Renovate to the custom regex manager for these tools or remove the overlapping Dependabot jobs.
"extends": [
"config:base",
":dependencyDashboard",
":semanticCommits"
.github/workflows/daily.yml:24
- The workflow runs at 00:00 UTC, but Renovate is allowed only after 22:00 on Monday. The daily invocation therefore never falls inside the configured Monday window, so scheduled dependency and lock-file updates will not run. Align the cron with the configured window or remove the Renovate schedule restriction.
- cron: '0 0 * * *'
- Files reviewed: 6/6 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+25
to
+30
| # On changes to this workflow file | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - '.github/workflows/daily.yml' |
Comment on lines
+35
to
+42
| uses: eclipse-score/cicd-workflows/.github/workflows/daily.yml@cache | ||
| permissions: | ||
| contents: write | ||
| issues: write | ||
| pull-requests: write | ||
| pages: write | ||
| id-token: write | ||
| actions: write |
Comment on lines
+21
to
+23
| "schedule": [ | ||
| "after 10pm on Monday" | ||
| ], |
Comment on lines
+43
to
+44
| "\"url\":\\s*\"https://github\\.com/microsoft/apm/releases/download/v[^/]+/[^\"]+\"", | ||
| "\"sha256\":\\s*\"(?<currentDigest>[^\"]+)\"" |
| pages: write | ||
| id-token: write | ||
| actions: write | ||
| renovate: |
lurtz
reviewed
Sep 17, 2026
Comment on lines
+29
to
+30
| paths: | ||
| - '.github/workflows/daily.yml' |
Contributor
There was a problem hiding this comment.
Should this job also run, when .github/renovate.json5 is changed? Otherwise we will end up with broken main eventually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump opencode and apm and added renovate
Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information